FAPI: Fix segfault if json field is null. #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function json_object_object_get_ex does not create a json object for the parameter value in the case "key":null. This caused a segfault in json deserialization. Fixes: tpm2-software#2878 Signed-off-by: Juergen Repp <juergen_repp@web.de>
dEajL3kA
reviewed
Aug 1, 2024
There was a problem hiding this comment.
if (*sub_jso) {
return true;
} else {
return false;
}
could be simplified to:
return (*sub_jso);
There was a problem hiding this comment.
This could give some static code analysis alarms.
return !!(*sub_jso);
might however work.
But I also don't mind the explicit version.
There was a problem hiding this comment.
Nice solution return !!(*sub_jso); but i would prefer the explicit version. @AndreasFuchsTPM could you please approve the PR.
AndreasFuchsTPM
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function json_object_object_get_ex does not create a json object for the parameter value in the case "key":null. This caused a segfault in json deserialization.
Fixes: #2878