Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip tcti-spidev on 32bit architectures with 64bit time_t #2904

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bluca
Copy link
Contributor

@bluca bluca commented Oct 10, 2024

The tests fail, similarly to how they failed due to _FILE_OFFSET_BITS == 64 as fixed in 932b1e7

FAIL: test/unit/tcti-spidev
===========================

[==========] tests: Running 1 test(s).
[ RUN      ] tcti_spi_init_test
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
...
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:728:Tss2_Tcti_Spi_Helper_Init() Probing TPM failed
[  ERROR   ] --- 0xa000a != 0
[   LINE   ] --- test/unit/tcti-spidev.c:200: error: Failure!
[  FAILED  ] tcti_spi_init_test

@bluca
Copy link
Contributor Author

bluca commented Nov 28, 2024

@JuergenReppSIT gentle ping, any chance this could be looked at, please? It fixes unit tests in Debian

@JuergenReppSIT
Copy link
Member

@bluca I used -D_TIME_BITS=64 with gcc, did run the unit test on 32bit raspian and the test passed.

@bluca
Copy link
Contributor Author

bluca commented Nov 28, 2024

Raspbian is a different distribution. Check Debian armhf/armel instead to reproduce it

@JuergenReppSIT
Copy link
Member

Raspbian is a different distribution. Check Debian armhf/armel instead to reproduce it

That's true. But I do not want to skip a test an platform where it works.

@JuergenReppSIT
Copy link
Member

@bluca If there would be a new push force please rebase tss. So also the integration test on FreeBSD should work and no other tests will be cancelled.

@bluca
Copy link
Contributor Author

bluca commented Nov 28, 2024

Raspbian is a different distribution. Check Debian armhf/armel instead to reproduce it

That's true. But I do not want to skip a test an platform where it works.

Why would it be skipped? They didn't do a t64 transition iirc?

The tests fail, similarly to how they failed due to _FILE_OFFSET_BITS == 64
as fixed in 932b1e7

FAIL: test/unit/tcti-spidev
===========================

[==========] tests: Running 1 test(s).
[ RUN      ] tcti_spi_init_test
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:48:platform_spi_acquire() SPI acquire failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
...
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:164:spi_tpm_helper_log_register_access() READ register 0xd40f00 (4 bytes) failed in transaction start
ERROR:tcti:src/tss2-tcti/tcti-spidev.c:68:platform_spi_release() SPI release failed: Bad file descriptor
ERROR:tcti:src/tss2-tcti/tcti-spi-helper.c:728:Tss2_Tcti_Spi_Helper_Init() Probing TPM failed
[  ERROR   ] --- 0xa000a != 0
[   LINE   ] --- test/unit/tcti-spidev.c:200: error: Failure!
[  FAILED  ] tcti_spi_init_test

Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
@bluca bluca force-pushed the arm_test_fail_timet64 branch from c627e59 to 10b6023 Compare November 28, 2024 17:06
@JuergenReppSIT JuergenReppSIT self-requested a review November 28, 2024 17:36
@JuergenReppSIT JuergenReppSIT merged commit d68270b into tpm2-software:master Nov 28, 2024
25 checks passed
@JuergenReppSIT
Copy link
Member

Why would it be skipped? They didn't do a t64 transition iirc?

@bluca That's true. Thank you for the PR.

@bluca bluca deleted the arm_test_fail_timet64 branch November 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants