Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MotherDuck adapter #191

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add MotherDuck adapter #191

wants to merge 13 commits into from

Conversation

Doekeb
Copy link

@Doekeb Doekeb commented Nov 7, 2024

Add an adapter, based on the existing DuckDB adapter, for MotherDuck (cloud-hosted serverless DuckDB).

This also improves the output format of the existing DuckDB adapter to use duckbox instead of columns.

For example:
Before:
image

After:
image

Note in particular the presence of data types in column headers.

TODO:

  • Basic functionality with :DB md: [query] and :DB md:[database] [query]
  • List tables for basic integration with vim-dadbod-ui
  • Add documentation

@Doekeb
Copy link
Author

Doekeb commented Nov 7, 2024

@tpope I was mostly able to figure out the interface, but I'm not completely sure on what canonicalize is supposed to do or what it's used for. Right now I have it set up to return the URL unchanged. MotherDuck CLI assumes a token is stored as an environment variable so the connection URL is extremely simple.

Aside from the documentation TODO, I'm interested to hear if you think anything else is missing!

@Doekeb Doekeb changed the title MotherDuck adapter Add MotherDuck adapter Nov 8, 2024
@Doekeb Doekeb marked this pull request as ready for review November 8, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant