Skip to content

Commit

Permalink
[TASK] Remove unused extConf property
Browse files Browse the repository at this point in the history
  • Loading branch information
christianbltr committed Apr 12, 2024
1 parent 00648ce commit 392941b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions Classes/Controller/BackendModuleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class BackendModuleController
protected ModuleTemplate $moduleTemplate;
protected int $pageId = 0;
protected ?string $do;
protected array $extConf;
protected PageRenderer $pageRenderer;
protected IndexerStatusService $indexerStatusService;

Expand All @@ -73,7 +72,6 @@ public function __invoke(ServerRequestInterface $request): ResponseInterface
$GLOBALS['LANG']->includeLLFile('LLL:EXT:ke_search/Resources/Private/Language/locallang_mod.xlf');

$moduleTemplate = $this->moduleTemplateFactory->create($request);
$this->extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('ke_search');
$this->pageId = (int)($request->getQueryParams()['id'] ?? 0);
$this->do = $request->getQueryParams()['do'] ?? null;
$backendUser = $this->getBackendUser();
Expand Down Expand Up @@ -158,7 +156,7 @@ public function startIndexingAction(ServerRequestInterface $request, ModuleTempl
// action: start indexer or remove lock
if ($this->do == 'startindexer') {
// start indexing in verbose mode with cleanup process
$content .= $indexer->startIndexing(true, $this->extConf, '', $indexingMode);
$content .= $indexer->startIndexing(true, [], '', $indexingMode);
} else {
if ($this->do == 'rmLock') {
// remove lock from registry - admin only!
Expand Down
4 changes: 2 additions & 2 deletions Classes/Indexer/IndexerRunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ public function __construct(
/**
* function startIndexing
* @param $verbose boolean if set, information about the indexing process is returned, otherwise processing is quiet
* @param $extConf array extension config array from EXT Manager
* @param $_unused array unused parameter, kept for compatibility
* @param $mode string "CLI" if called from command line, otherwise empty
* @param int $indexingMode integer full or incremental indexing (possible values: IndexerBase::INDEXING_MODE_FULL or IndexerBase::INDEXING_MODE_INCREMENTAL)
* @return string output is done only if param $verbose is true
*/
public function startIndexing($verbose = true, $extConf = [], $mode = '', $indexingMode = IndexerBase::INDEXING_MODE_FULL)
public function startIndexing($verbose = true, array $_unused = [], $mode = '', $indexingMode = IndexerBase::INDEXING_MODE_FULL)
{
$content = '<div class="row" id="kesearch-indexer-report"><div class="col-md-8">';
$content .= '<div class="alert alert-info">';
Expand Down

0 comments on commit 392941b

Please sign in to comment.