getMeでDBを叩くように変更

[comavius]

#725

• getMeでセッションからユーザーを取ってくる実装からDBからに変更
• DBにユーザーが存在しない場合にセッションのユーザーをDBに追加

[H1rono]

とりあえずこれ
あとテストの方を直す必要があります

[H1rono]

まずは変数名をcamelCaseにしてください

[H1rono]

if err != nilでreturn nil, errとするのは忘れずにお願いします 🙏

[H1rono]

テスト頑張ってください

--- FAIL: TestHandlers_GetMe (0.00s)
    --- FAIL: TestHandlers_GetMe/Success (0.00s)
        user.go:95: Unexpected call to *mock_model.MockUserRepository.GetUserByID([context.Background.WithValue(sessions.contextKey, *sessions.Registry) c[76](https://github.com/traPtitech/Jomon/actions/runs/11745765123/job/32723973343?pr=763#step:8:77)069f6-ae57-40ee-be7d-b7674589867a]) at /home/runner/work/Jomon/Jomon/router/user.go:95 because: there are no expected calls of the method "GetUserByID" for that receiver

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 25.23%. Comparing base (6b2f353) to head (c83bbe0).
Report is 10 commits behind head on v2.

Files with missing lines	Patch %	Lines
router/user.go	22.22%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##               v2     #763   +/-   ##
=======================================
  Coverage   25.23%   25.23%           
=======================================
  Files         148      147    -1     
  Lines       30578    30572    -6     
=======================================
- Hits         7716     7715    -1     
+ Misses      21986    21980    -6     
- Partials      876      877    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[H1rono]

この変更は必要なんでしょうか？使ってないように見えるんですが

[Hueter57]

この変更がないと予想される返り値のJSONのフィールド名が小文字なのに、実際は大文字が返ってきて違いますよと言われたので変更しました。

[Hueter57]

手元で実行したら、こんな感じにエラー出ました

--- FAIL: TestHandlers_GetMe (0.00s)
    --- FAIL: TestHandlers_GetMe/Success (0.01s)
        user_test.go:334: 
                Error Trace:    /home/kohsuke/SysAd/Jomon/router/user_test.go:334
                Error:          Not equal: 
                                expected: "{\"id\":\"7a045fc6-0a22-4b71-b989-93527fef1afc\",\"name\":\"9LcsCLBUWB7xgcntarNB\",\"display_name\":\"aRN8KgouLCcUuD9QtnUY\",\"admin\":true,\"created_at\":\"2024-11-15T00:15:44.088301571+09:00\",\"updated_at\":\"2024-11-15T00:15:44.088301571+09:00\",\"deleted_at\":null}"
                                actual  : "{\"ID\":\"7a045fc6-0a22-4b71-b989-93527fef1afc\",\"Name\":\"9LcsCLBUWB7xgcntarNB\",\"DisplayName\":\"aRN8KgouLCcUuD9QtnUY\",\"Admin\":true,\"CreatedAt\":\"2024-11-15T00:15:44.088301571+09:00\",\"UpdatedAt\":\"2024-11-15T00:15:44.088301571+09:00\",\"DeletedAt\":null}"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -{"id":"7a045fc6-0a22-4b71-b989-93527fef1afc","name":"9LcsCLBUWB7xgcntarNB","display_name":"aRN8KgouLCcUuD9QtnUY","admin":true,"created_at":"2024-11-15T00:15:44.088301571+09:00","updated_at":"2024-11-15T00:15:44.088301571+09:00","deleted_at":null}
                                +{"ID":"7a045fc6-0a22-4b71-b989-93527fef1afc","Name":"9LcsCLBUWB7xgcntarNB","DisplayName":"aRN8KgouLCcUuD9QtnUY","Admin":true,"CreatedAt":"2024-11-15T00:15:44.088301571+09:00","UpdatedAt":"2024-11-15T00:15:44.088301571+09:00","DeletedAt":null}
                Test:           TestHandlers_GetMe/Success

[H1rono]

変更前はuserの型がrouter.Userだった(model.Userではなく)ので上手くできてたっぽいですね、ここでもそれに合わせてmodel.User型からrouter.User型への変換を行って欲しいです(適宜↓のようなヘルパー関数を作ってください)

package router

func userFromModelUser(u model.User) User { ... }