Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ホスト名の正規化 #754

Merged
merged 3 commits into from
Oct 22, 2023
Merged

ホスト名の正規化 #754

merged 3 commits into from
Oct 22, 2023

Conversation

pirosiki197
Copy link
Contributor

なぜやるか

#753

やったこと

ホスト名をlowercaseに正規化するようにした

やらなかったこと

dashboard側の変更

資料

motoki317
motoki317 reviewed Oct 21, 2023
View reviewed changes
Copy link
Member

@motoki317 motoki317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます～

domainに置かれてて良いかんじですね。
一応、ValidateDomain関数の中でも、大文字が含まれていないことを検証してもらえますか？（と、テストケースの追加をできると素晴らしい）

@motoki317 motoki317 linked an issue Oct 21, 2023 that may be closed by this pull request
ホスト名をlowercaseに正規化する #753
Closed
motoki317
motoki317 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@motoki317 motoki317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かんぺきです

@pirosiki197 pirosiki197 merged commit c47d88d into main Oct 22, 2023
10 checks passed
@pirosiki197 pirosiki197 deleted the fix/normalize-host-name branch October 22, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motoki317 motoki317 motoki317 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ホスト名をlowercaseに正規化する
2 participants
@pirosiki197 @motoki317