feat(gateway): Public key settings to allow name and creation date to… #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evans で動作確認 |
Closed
|
多分良さそうです nameが空でも通るかどうかをevansかテストで確認してもらえると良いと思います |
nameが空の場合の挙動です。omitempty で name フィールドが出力に含まれない形になります |
motoki317
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
これを入れたら、wikiの「スキーマが変わった」のセクションを参考にしてリリース・デプロイしてほしいです
https://wiki.trap.jp/SysAd/dev/NeoShowcase/Administration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるか
#781 に対応
やったこと
やらなかったこと
資料