Static App の URL がアップデートできなかったバグを修正 #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod backend + PR dashboard) → https://984.ns-preview.trapti.tech/ |
eyemono-moe
reviewed
Dec 13, 2024
| // Static App ではフォームに表示されないので undefined になってしまう | ||
| // そのままだと invalid になって設定を変更できないのでデフォルト値を設定する | ||
| h2c: v.pipe( | ||
| v.optional(v.boolean()), |
There was a problem hiding this comment.
レビュータイミング逃しちゃった ごめん 🙇
v.optional()の第二引数でデフォルト値を指定できる( https://valibot.dev/api/optional/ )のでv.optional(v.boolean(), false)って書けるかもです
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるか
バグ修正
やったこと
h2c (= false) と httpPort (= 80) のデフォルト値を送信するように
やらなかったこと
N/A
資料
N/A