dashboard: Sleepを表示 / Filter部分にカウントを表示 #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod backend + PR dashboard) → https://993.ns-preview.trapti.tech/ |
motoki317
force-pushed
the
dashboard/impr-status
branch
from
2ed5a18 to
4befd1a
Compare
motoki317
force-pushed
the
dashboard/impr-status
branch
from
4befd1a to
6365f94
Compare
motoki317
force-pushed
the
dashboard/impr-status
branch
from
6365f94 to
f5a4a26
Compare
cp-20
approved these changes
Jan 7, 2025
dashboard/src/libs/application.tsx
Outdated
Comment on lines
186
to
191
| const filteredReposByOrigin = () => { | ||
| return repos.filter((r) => origins.includes(repositoryURLToOrigin(r.url))) ?? [] | ||
| } | ||
| const filteredApps = () => { | ||
| return apps.filter((a) => statuses.includes(applicationState(a))) ?? [] | ||
| } |
There was a problem hiding this comment.
細かいですが、ここをわざわざ関数にする必要はない気がします
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるか
やったこと
変なところがあれば教えてもらえると助かります 🙇
やらなかったこと
資料