package.jsonの加筆 #27
Merged
package.jsonの加筆 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9-sukyu
reviewed
Feb 22, 2024
.eslintrc.js
Outdated
| @@ -18,6 +18,7 @@ module.exports = { | |||
| 'vue/eqeqeq': 'error', | |||
| '@typescript-eslint/consistent-type-imports': 'error', | |||
| 'vue/require-default-prop': 'off', | |||
| '@typescript-eslint/no-explicit-any': 'off', | |||
There was a problem hiding this comment.
これを書くと、手で書いたファイルを含めてすべてのファイルにおいてany型を許容してしまうことになりそうです。
src/apis/openAPI.ts のみでany型を許容しないようにするために、.eslintignore にsrc/apis/openAPI.tsを含めるのがよさそう
There was a problem hiding this comment.
src/apis/openAPI.tsで永久にany型が自動生成され続けるので、openAPI.tsのみでany型を許容するほうがパット見良さそう…？
ただ、oneOfが他のところでも使われている以上、他のファイルでもany型はそこそこ出てきそうな気はします
There was a problem hiding this comment.
ESLintのoverridesフィールドを使うと良さそうです
https://blog.popweb.dev/programming/javascript/eslint-overrides/
cp-20
reviewed
Feb 24, 2024
src/apis/client.ts
Outdated
|
|
||
| // global configuration | ||
| fetcher.configure({ | ||
| baseUrl: '', //どのURLを参照するかわからなかったので空にした |
cp-20
requested changes
Feb 25, 2024
cp-20
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openapi-typescript導入+package.jsonに記載
ただ生成した.tsから型を自動的に決めるコードの実装の仕方が一向にわからない