Skip to content

テーマ設定のUI改善 #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 10, 2024
Merged

テーマ設定のUI改善 #4154

merged 21 commits into from
May 10, 2024

Conversation

Nattuki
Copy link
Contributor

@Nattuki Nattuki commented Nov 17, 2023

#2203
設計図通りにテーマ設定のレイアウト・様式変更してみました。

変更前
スクリーンショット 2023-11-17 21 27 37

変更後
スクリーンショット 2023-11-17 21 27 58

@Nattuki Nattuki requested a review from mehm8128 November 17, 2023 12:33
@Nattuki Nattuki self-assigned this Nov 17, 2023
@github-actions GitHub Actions
Copy link

Preview (prod) → https://4154-prod.traq-preview.trapti.tech/
Preview (dev) → https://4154-dev.traq-preview.trapti.tech/

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (4c3688d) to head (e585c73).
Report is 182 commits behind head on master.

❗ Current head e585c73 differs from pull request most recent head a53e653. Consider uploading reports for the commit a53e653 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4154   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files          66       66           
  Lines        4719     4719           
  Branches      564      564           
=======================================
  Hits         4075     4075           
  Misses        638      638           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mehm8128
mehm8128 suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます！
いくつかあるので、対応お願いします

@mehm8128 mehm8128 self-requested a review November 26, 2023 14:31
mehm8128
mehm8128 suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動きは大体よさそうです！
細かいところ書いたので確認してほしいです:pray:

src/components/Modal/EditThemeModal/EditThemeModal.vue Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should
他のに合わせてSettingsThemeEditとかにしてほしいです:pray:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、すみませんこれファイル名もディレクトリ名も、SettingsThemeEditModalですね(Modalつける)

src/components/Modal/EditThemeModal/EditThemeModal.vue Outdated
</modal-frame>
</template>

<script lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits
歴史的経緯により元は分割されてましたが、多分<script lang="ts" setup>の方にまとめちゃって大丈夫です

@mehm8128
Copy link
Contributor

あと、再レビューしてOKな状態になったらここから再レビュー依頼お願いします
image

@Nattuki Nattuki requested a review from mehm8128 December 4, 2023 11:03
mehm8128
mehm8128 reviewed Dec 26, 2023
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4154 (comment)
ここだけ直してほしいです:pray:
あとはよさそうです

mehm8128
mehm8128 reviewed Dec 26, 2023
View reviewed changes
src/components/UI/FormRadio.vue Outdated
@@ -1,5 +1,5 @@
<template>
<label :class="$style.label">
<label :class="$style.label" :aria-checked="isChecked">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits
あ、ここ:aria-checked="isChecked"消し忘れだと思うので消しておいてほしいです

mehm8128
mehm8128 reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見てたら追加で気づいたので🙏

src/views/Settings/ThemeTab.vue Outdated
Comment on lines 110 to 112
display: flex;
align-items: center;
font-weight: bold;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should

display: flex;
align-items: center;

はFormRadio側で定義してるから多分いらなくて、font-weight: bold;は多分全ラジオボタンで共通になるのでFormRadio側に移動してほしいです🙏

src/views/Settings/ThemeTab.vue Outdated
.content {
margin-left: 12px;
margin-left: 0px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits
これ前に消したっけ？復活してそう

@Nattuki Nattuki requested a review from mehm8128 May 9, 2024 07:53
mehm8128
mehm8128 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです、ありがとうございました！

@mehm8128 mehm8128 merged commit 3cf4790 into master May 10, 2024
9 checks passed
@mehm8128 mehm8128 deleted the Natsuki/theme-alter branch May 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSlime-s SSlime-s SSlime-s left review comments

@mehm8128 mehm8128 mehm8128 approved these changes

Assignees

@Nattuki Nattuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nattuki @mehm8128 @SSlime-s