Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知のインラインリプライを使ったときにアイコンが切り替わらないバグ修正 #4204

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

Nagarei
Copy link
Contributor

@Nagarei Nagarei commented Jan 1, 2024

通知のインラインリプライを使ったときにアイコンが切り替わらないバグ修正

このあたりを参考に直しました。

const [state, restoring, restoringPromise] = useIndexedDbValue(
'store/domain/me',

https://github.com/traPtitech/traQ_S-UI/blob/master/docs/store.md#各モジュールについて

IndexedDB を使う際はuseIndexedDbValueを利用してストア名をstore/${id}にすること

通知からinline replyしたときに、自分のアイコンが取得できないバグ修正
getMeに失敗した場合に他人のアイコンが残ってしまうので、削除対応
Copy link

github-actions bot commented Jan 1, 2024

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f0340c) 0.00% compared to head (110c1c4) 86.35%.

❗ Current head 110c1c4 differs from pull request most recent head 927f961. Consider uploading reports for the commit 927f961 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4204       +/-   ##
===========================================
+ Coverage        0   86.35%   +86.35%     
===========================================
  Files           0       66       +66     
  Lines           0     4719     +4719     
  Branches        0      564      +564     
===========================================
+ Hits            0     4075     +4075     
- Misses          0      638      +638     
- Partials        0        6        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです!

@nokhnaton nokhnaton merged commit 7296377 into traPtitech:master Nov 11, 2024
9 checks passed
@Nagarei Nagarei deleted the fix/sw-inlinereply-icon branch January 3, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants