Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove old qall #4472

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Feat/remove old qall #4472

merged 6 commits into from
Jan 23, 2025

Conversation

mathsuky
Copy link
Contributor

古いqall関連のコードとrtc周りのコードを削除
ただし,画面要素についてはデザインが確定していないのもあって,使用するかどうか定かでないものはそのまま残してある。

Copy link

@mathsuky mathsuky merged commit b3fd388 into feat/qall_remake Jan 23, 2025
5 of 8 checks passed
@mathsuky mathsuky deleted the feat/remove-old-qall branch January 23, 2025 14:20
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 9.19%. Comparing base (bb475ba) to head (ee229d2).
Report is 7 commits behind head on feat/qall_remake.

Files with missing lines Patch % Lines
...avigationContent/QallController/QallController.vue 0.00% 12 Missing ⚠️
...annelView/ChannelHeader/ChannelHeaderToolsList.vue 0.00% 10 Missing ⚠️
...annelView/ChannelHeader/ChannelHeaderToolsMenu.vue 0.00% 10 Missing ⚠️
...n/NavigationBar/ChannelList/ChannelElementName.vue 0.00% 6 Missing ⚠️
...igationContent/QallController/QallDetailsPanel.vue 0.00% 6 Missing ⚠️
src/store/app/rtcSettings.ts 0.00% 4 Missing ⚠️
...annelView/ChannelSidebar/ChannelSidebarContent.vue 0.00% 3 Missing ⚠️
...s/Main/NavigationBar/NavigationContent/HomeTab.vue 0.00% 3 Missing ⚠️
...ionContent/QallController/QallDetailsPanelUser.vue 0.00% 2 Missing ⚠️
src/App.vue 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/qall_remake   #4472      +/-   ##
===================================================
+ Coverage              8.89%   9.19%   +0.29%     
===================================================
  Files                   664     659       -5     
  Lines                 29158   28227     -931     
  Branches                521     521              
===================================================
  Hits                   2595    2595              
+ Misses                26557   25626     -931     
  Partials                  6       6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant