-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
グループメンバーの一括追加・削除の実装 #4476
グループメンバーの一括追加・削除の実装 #4476
Conversation
Preview (prod) → https://4476-prod.traq-preview.trapti.tech/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4476 +/- ##
======================================
Coverage 8.82% 8.83%
======================================
Files 671 671
Lines 29450 29444 -6
Branches 522 524 +2
======================================
+ Hits 2599 2601 +2
+ Misses 26845 26837 -8
Partials 6 6 ☔ View full report in Codecov by Sentry. |
ここ↓ でのスキーマ変更も盛り込んだ PR となってしまっています お手数をおかけいたしますが、ご確認をお願いします |
729b8ab
to
99423db
Compare
try { | ||
for (const userId of userIds.value) { | ||
if (reqIds.length === 1 && reqIds[0]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ別に長さが1かどうかで分けなくていい気がしているのですが、どうでしょう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにそのほうが処理が楽なんですが、せっかくあるなら既存のエンドポイントも叩くのを残しておこうかなぁと思ってしまって残してました
このメッセージを入力している間に、そういえば bot とかが使うならもとのエンドポイントにもちゃんと役割がありそうだな、と思ったのでとりあえずは処理が楽な方にしようと思います
ありがとうございます!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそう!
traPtitech/traQ#2484 に対応したもの
実装が完了し次第、 WIP を外します