Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

グループメンバーの一括追加・削除の実装 #4476

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

Pugma
Copy link
Contributor

@Pugma Pugma commented Jan 24, 2025

traPtitech/traQ#2484 に対応したもの
実装が完了し次第、 WIP を外します

Copy link

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 8.83%. Comparing base (395e21b) to head (c29a9fa).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../Modal/GroupMemberAddModal/GroupMemberAddModal.vue 0.00% 5 Missing ⚠️
src/components/GroupManager/GroupMemberList.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #4476   +/-   ##
======================================
  Coverage    8.82%   8.83%           
======================================
  Files         671     671           
  Lines       29450   29444    -6     
  Branches      522     524    +2     
======================================
+ Hits         2599    2601    +2     
+ Misses      26845   26837    -8     
  Partials        6       6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pugma Pugma marked this pull request as ready for review January 24, 2025 07:42
@Pugma Pugma requested a review from nokhnaton January 24, 2025 07:42
@Pugma
Copy link
Contributor Author

Pugma commented Jan 24, 2025

ここ↓ でのスキーマ変更も盛り込んだ PR となってしまっています
traPtitech/traQ@26c8e9b

お手数をおかけいたしますが、ご確認をお願いします

@Pugma Pugma force-pushed the feat/groupMembersBulkInsertDeletion branch from 729b8ab to 99423db Compare January 28, 2025 05:05
try {
for (const userId of userIds.value) {
if (reqIds.length === 1 && reqIds[0]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ別に長さが1かどうかで分けなくていい気がしているのですが、どうでしょう?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにそのほうが処理が楽なんですが、せっかくあるなら既存のエンドポイントも叩くのを残しておこうかなぁと思ってしまって残してました
このメッセージを入力している間に、そういえば bot とかが使うならもとのエンドポイントにもちゃんと役割がありそうだな、と思ったのでとりあえずは処理が楽な方にしようと思います

ありがとうございます!

@Pugma Pugma requested a review from nokhnaton January 28, 2025 06:49
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう!

@nokhnaton nokhnaton merged commit d3c98d1 into master Jan 28, 2025
10 of 11 checks passed
@nokhnaton nokhnaton deleted the feat/groupMembersBulkInsertDeletion branch January 28, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants