Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

古いiOSで正規表現の後読みが使えない問題を修正 #4507

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

nokhnaton
Copy link
Contributor

No description provided.

Copy link

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.83%. Comparing base (395e21b) to head (976f466).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #4507   +/-   ##
======================================
  Coverage    8.82%   8.83%           
======================================
  Files         671     671           
  Lines       29450   29452    +2     
  Branches      522     524    +2     
======================================
+ Hits         2599    2601    +2     
  Misses      26845   26845           
  Partials        6       6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作は良さそうです!

1つ言うなら、replaceMention/replaceChannel 内で余計にmatchしちゃってるので、ちょっと無駄かもです が、パフォーマンスを大きく気にすることもないと思うのでこのままでも良いと思います!

@nokhnaton
Copy link
Contributor Author

素早いレビューありがとう!
replaceMention/replaceChannel内でMatchしてるのはURL始まりのものを処理の対象から外すためなので必要かなーって思ってます

@nokhnaton nokhnaton merged commit 46bb9c6 into master Jan 28, 2025
12 checks passed
@nokhnaton nokhnaton deleted the fix/cant_use_lookbehind_on_old_ios_safari branch January 28, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants