Open
Conversation
|
Preview (prod) → https://4776-prod.traq-preview.trapti.tech/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4776 +/- ##
==========================================
+ Coverage 61.32% 61.50% +0.17%
==========================================
Files 100 100
Lines 2904 2904
Branches 604 604
==========================================
+ Hits 1781 1786 +5
+ Misses 1031 1022 -9
- Partials 92 96 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c72ff12 to
5869b94
Compare
5869b94 to
2db9d3e
Compare
2db9d3e to
ae7197e
Compare
ae7197e to
a6a9090
Compare
eeca312 to
2062a35
Compare
ec076c9 to
9366e56
Compare
9366e56 to
1da05e9
Compare
1da05e9 to
1213e45
Compare
1213e45 to
b0e8ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
サービスグリッドの配置をドラッグで弄れるようになります.(タッチデバイスの場合は長押し)
useSortablecomposable として切り出すapp/appListstore を作成useGridLayoutcomposable を作成StampPaletteEditorSortableStampListの実装をuseSortableを用いたものにするなぜこの PR を入れたいのか
cf. https://q.trap.jp/channels/services/feedback?message=01992ec4-f1a4-7426-aa35-9c1c28e4aa89
PR を出す前の確認事項
懸念点