Skip to content

feat(app-list): 並び替え可能なサービス一覧#4776

Open
uni-kakurenbo wants to merge 6 commits intomasterfrom
feat/rearrangeable-app-list
Open

feat(app-list): 並び替え可能なサービス一覧#4776
uni-kakurenbo wants to merge 6 commits intomasterfrom
feat/rearrangeable-app-list

Conversation

@uni-kakurenbo
Copy link
Contributor

@uni-kakurenbo uni-kakurenbo commented Sep 10, 2025

概要

サービスグリッドの配置をドラッグで弄れるようになります.(タッチデバイスの場合は長押し)

  • refactor: sortablejs 関連のコードを useSortable composable として切り出す
  • feat: サービス一覧の並び順を保存するための app/appList store を作成
  • feat: CSS によって描画された Grid の行列情報を取得する useGridLayout composable を作成
  • feat: サービス一覧をドラッグアンドドロップによって並び替えられるようにする
    • feat: 並び順をデフォルトのものにリセットするためのボタンを配置
  • refactor: 並び順を保存するための処理を,sortablejs の store オプションを用いたより簡潔なものに変更
  • refactor: StampPaletteEditorSortableStampList の実装を useSortable を用いたものにする

なぜこの PR を入れたいのか

cf. https://q.trap.jp/channels/services/feedback?message=01992ec4-f1a4-7426-aa35-9c1c28e4aa89

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

懸念点

  • 「並び順をリセット」ボタンの配置やデザインについては議論の余地があると思います.

@github-actions
Copy link

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.50%. Comparing base (f873ea3) to head (b0e8ffe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4776      +/-   ##
==========================================
+ Coverage   61.32%   61.50%   +0.17%     
==========================================
  Files         100      100              
  Lines        2904     2904              
  Branches      604      604              
==========================================
+ Hits         1781     1786       +5     
+ Misses       1031     1022       -9     
- Partials       92       96       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo changed the title 並び替え可能なサービス一覧 feat: 並び替え可能なサービス一覧 Sep 10, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from c72ff12 to 5869b94 Compare September 10, 2025 08:40

This comment was marked as outdated.

@uni-kakurenbo uni-kakurenbo self-assigned this Sep 10, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from 5869b94 to 2db9d3e Compare September 10, 2025 09:10

This comment was marked as resolved.

@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from 2db9d3e to ae7197e Compare September 10, 2025 09:13
@uni-kakurenbo uni-kakurenbo requested a review from a team September 11, 2025 11:45
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from ae7197e to a6a9090 Compare September 12, 2025 01:18
@uni-kakurenbo uni-kakurenbo changed the title feat: 並び替え可能なサービス一覧 feat: 並び替え可能なサービスグリッド Sep 12, 2025
@uni-kakurenbo uni-kakurenbo changed the title feat: 並び替え可能なサービスグリッド feat: 並び替え可能なサービス一覧 Sep 12, 2025
@uni-kakurenbo uni-kakurenbo added the enhancement New feature or request label Sep 12, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch 3 times, most recently from eeca312 to 2062a35 Compare September 13, 2025 09:59
@Takeno-hito Takeno-hito requested review from Takeno-hito and removed request for a team September 13, 2025 10:08
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch 5 times, most recently from ec076c9 to 9366e56 Compare September 17, 2025 03:11
@uni-kakurenbo uni-kakurenbo changed the title feat: 並び替え可能なサービス一覧 feat(app-list): 並び替え可能なサービス一覧 Sep 22, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from 9366e56 to 1da05e9 Compare September 23, 2025 04:19
@uni-kakurenbo uni-kakurenbo moved this from Inbox to In review in traQ Client Sep 26, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from 1da05e9 to 1213e45 Compare November 9, 2025 03:57
@uni-kakurenbo uni-kakurenbo force-pushed the feat/rearrangeable-app-list branch from 1213e45 to b0e8ffe Compare November 9, 2025 04:07
@Takeno-hito Takeno-hito moved this from In review to Need Discussion in traQ Client Dec 25, 2025
@Takeno-hito Takeno-hito removed their request for review January 9, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Need Discussion

Development

Successfully merging this pull request may close these issues.

3 participants