Skip to content

feat(search): グループに対するメッセージ検索#4851

Open
uni-kakurenbo wants to merge 10 commits intomasterfrom
feat/message-search-for-groups
Open

feat(search): グループに対するメッセージ検索#4851
uni-kakurenbo wants to merge 10 commits intomasterfrom
feat/message-search-for-groups

Conversation

@uni-kakurenbo
Copy link
Contributor

@uni-kakurenbo uni-kakurenbo commented Sep 30, 2025

概要

#4837 を内包しています

  • feat: to/from:group_name, to/from:@group_name, to/from:@!user_name, to/from:@&group_name クエリのサポートを追加

    • 現在の仕様との互換性のため,ユーザー名が優先される.すなわち,traQ という名前のユーザーとグループが同時に存在した場合,from:traQfrom:@traQfrom:@!traQ と同値になる
    • @!@& というシンボルは discord の <@!user-id>, <@&role-id> という記法を参考にした
  • feat: to(groups): prefix のサポートを追加

    • to:@!user_name クエリによる検索の結果に,そのユーザが属する group 宛てのメンションも含むようになる
    • (同名のユーザーが存在しないならば) to(groups):group_name, to(groups):@group_name, to(groups):@&group_name はすべて to:@&group_name と同値になる
    • 構文の妥当性については要検討

なぜこの PR を入れたいのか

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

@github-actions
Copy link

@uni-kakurenbo uni-kakurenbo marked this pull request as draft September 30, 2025 15:46
@uni-kakurenbo uni-kakurenbo force-pushed the feat/message-search-for-groups branch from 04be767 to 66c9b30 Compare September 30, 2025 15:54
@uni-kakurenbo uni-kakurenbo self-assigned this Sep 30, 2025
@uni-kakurenbo uni-kakurenbo added enhancement New feature or request feat:message labels Sep 30, 2025
@uni-kakurenbo uni-kakurenbo moved this from Inbox to In progress in traQ Client Sep 30, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/message-search-for-groups branch from 66c9b30 to 94aa188 Compare October 1, 2025 03:17
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.00%. Comparing base (ecb0d1d) to head (27fc19e).

Files with missing lines Patch % Lines
src/lib/searchMessage/queryParser.ts 86.36% 0 Missing and 3 partials ⚠️
src/store/entities/groups.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4851      +/-   ##
==========================================
- Coverage   61.01%   61.00%   -0.01%     
==========================================
  Files         101      101              
  Lines        2970     2995      +25     
  Branches      615      626      +11     
==========================================
+ Hits         1812     1827      +15     
- Misses       1061     1071      +10     
  Partials       97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo marked this pull request as ready for review December 30, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feat:message

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

グループに向けたメンションの検索ができない

1 participant