Skip to content

fix: メッセージスクロール周りの改修#5004

Draft
yas-ako wants to merge 19 commits intomasterfrom
fix/message-scroller-layout-shift
Draft

fix: メッセージスクロール周りの改修#5004
yas-ako wants to merge 19 commits intomasterfrom
fix/message-scroller-layout-shift

Conversation

@yas-ako
Copy link
Member

@yas-ako yas-ako commented Dec 31, 2025

概要

  • refactor: useMessageScroller を導入してメッセージスクロール周りのロジックを統合・リファクタリング
  • fix: 初回ロード時にスクロール位置が末尾からわずかにズレる問題を修正
  • fix: WebKit 環境で画像サイズが小さく表示されていた問題を修正
  • fix: コードブロックが含まれる場合もメッセージの高さを監視する
  • fix: ResizeObserver の登録を待ってから追加の要素を描画する
  • feat: 初回ロード時にスケルトンを表示する
  • feat: スクロール速度に応じてメッセージを読み込むまでの閾値を動的に調整する

なぜこの PR を入れたいのか

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

@yas-ako yas-ako requested a review from a team December 31, 2025 13:29
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.64%. Comparing base (86d1ed2) to head (54c4ec0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5004      +/-   ##
==========================================
- Coverage   62.77%   62.64%   -0.13%     
==========================================
  Files         108      108              
  Lines        3097     3100       +3     
  Branches      630      630              
==========================================
- Hits         1944     1942       -2     
- Misses       1040     1048       +8     
+ Partials      113      110       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch from d20401c to d0690a0 Compare January 2, 2026 02:19
@uni-kakurenbo uni-kakurenbo marked this pull request as ready for review January 2, 2026 06:45
@uni-kakurenbo uni-kakurenbo added the bug Something isn't working label Jan 2, 2026
@uni-kakurenbo uni-kakurenbo moved this from Inbox to In review in traQ Client Jan 2, 2026
@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch from b4077b5 to b65804b Compare January 2, 2026 07:10
@uni-kakurenbo uni-kakurenbo mentioned this pull request Jan 2, 2026
2 tasks
@uni-kakurenbo uni-kakurenbo changed the title メッセージを読み込んだ際にスクロール位置が下にずれてしまう問題を修正する(draft) fix: メッセージを読み込んだ際にスクロール位置が下にずれてしまう問題を修正 Jan 2, 2026
@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch 4 times, most recently from 789f4cd to cfb4b02 Compare January 3, 2026 01:53
@uni-kakurenbo uni-kakurenbo changed the title fix: メッセージを読み込んだ際にスクロール位置が下にずれてしまう問題を修正 fix: メッセージスクロール周りの改修 Jan 3, 2026
@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch 11 times, most recently from cdfff3d to a3cdf7a Compare January 3, 2026 16:04
@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch from 683a5e0 to 2ae9121 Compare January 4, 2026 00:07
@Takeno-hito Takeno-hito marked this pull request as draft January 22, 2026 12:58
@Takeno-hito Takeno-hito moved this from In review to In progress in traQ Client Jan 22, 2026
@yas-ako yas-ako force-pushed the fix/message-scroller-layout-shift branch from 2ae9121 to 3e6d712 Compare March 23, 2026 07:23
@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a9d11ad-200e-42dd-9288-5d33bb1b18d5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/message-scroller-layout-shift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch 5 times, most recently from 6e372fb to 3eebd28 Compare March 23, 2026 10:59
yas-ako and others added 19 commits March 23, 2026 20:02
@uni-kakurenbo uni-kakurenbo force-pushed the fix/message-scroller-layout-shift branch from 3eebd28 to 54c4ec0 Compare March 23, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment