Skip to content

traQの開発者環境で、即時リダイレクトされるバグの修正#5066

Open
enari-k wants to merge 5 commits intomasterfrom
traQ-registration-redirect-fix
Open

traQの開発者環境で、即時リダイレクトされるバグの修正#5066
enari-k wants to merge 5 commits intomasterfrom
traQ-registration-redirect-fix

Conversation

@enari-k
Copy link

@enari-k enari-k commented Feb 5, 2026

概要

traQの開発者環境で、新規登録画面では401エラーに対し即時リダイレクトされないようにしました

なぜこの PR を入れたいのか

issue#5065

動作確認の手順

image ログアウトした状態で、ログイン画面から新規登録ボタンを押して新規登録画面がリダイレクトせずに開けるようになったことを確認しました。

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

見てほしいところ・聞きたいことなど

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

@enari-k enari-k self-assigned this Feb 5, 2026
@enari-k enari-k requested a review from Takeno-hito February 5, 2026 13:30
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.54%. Comparing base (5cca56b) to head (2289fd6).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/store/domain/me.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5066      +/-   ##
==========================================
- Coverage   62.59%   62.54%   -0.05%     
==========================================
  Files         108      108              
  Lines        3096     3100       +4     
  Branches      629      632       +3     
==========================================
+ Hits         1938     1939       +1     
- Misses       1048     1051       +3     
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Takeno-hito Takeno-hito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装自体は問題なさそう!

ただ、prd 環境で registration のリンクを踏むと無限ループに陥ってそうなので確認してほしいです!
https://5066-prod.traq-preview.trapti.tech/registration

@enari-k enari-k requested a review from Takeno-hito February 23, 2026 13:26
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Caution

Review failed

The head commit changed during the review from ea1c7fc to 2289fd6.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch traQ-registration-redirect-fix

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants