Conversation
|
Preview (prod) → https://5070-prod.traq-preview.trapti.tech/ |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughチャンネル表示にトピック表示制御を追加するため、Componentに Changes
Sequence Diagram(s)sequenceDiagram
participant ChannelsTab as ChannelsTab
participant ChannelTree as ChannelTreeComponent
participant ChannelElement as ChannelElement
participant Topic as ChannelElementTopic
ChannelsTab->>ChannelTree: render(channels or filteredChannelTree, showTopic?, preventChildTopic?)
ChannelTree->>ChannelElement: render node (passes showTopic && !preventChildTopic)
ChannelElement->>ChannelElement: evaluate showTopic
alt showTopic == true
ChannelElement->>Topic: mount (prop: channel-id)
else showTopic == false
ChannelElement-->>Topic: not mounted
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5070 +/- ##
==========================================
+ Coverage 62.59% 62.64% +0.04%
==========================================
Files 108 108
Lines 3096 3100 +4
Branches 629 632 +3
==========================================
+ Hits 1938 1942 +4
Misses 1048 1048
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/lib/channelTree.ts (1)
68-84:⚠️ Potential issue | 🟠 MajorshouldSort が再帰呼び出しへ伝播していません。
shouldSort=false の場合でも子孫でソートが実行され、順序保持の意図が崩れます。再帰呼び出しにも shouldSort を渡してください。🧩 修正案
- const result = constructTree(child, channelEntities, subscribedChannels) + const result = constructTree( + child, + channelEntities, + subscribedChannels, + shouldSort + )
🤖 Fix all issues with AI agents
In `@src/components/Main/NavigationBar/NavigationContent/ChannelsTab.vue`:
- Around line 133-140: filteredChannelTree currently returns
constructTreeFromIds(...) directly, which can include archived child channels
when a parent matches; modify the computed to post-process the tree with
filterTrees to exclude archived nodes (use filteredChannels, channelsMap and
constructTreeFromIds to build the initial tree, then call filterTrees on that
result and remove nodes where node.archived is true) so archived children are
not shown in search results.
otukado
left a comment
otukado
left a comment
There was a problem hiding this comment.
検索ワードが親チャンネルと子チャンネル両方に含まれているときには、両方を表示した方がいいと思います 💪
2 participants
概要
チャンネル検索結果に他の部分と同様のチャンネルツリーを表示するようにしました。
なぜこの PR を入れたいのか
目的のチャンネルまで行きやすくするため。
（チャンネル名が重複してチャンネル検索が行いづらい場合、その親チャンネルを検索し、そこに飛んでから子チャンネルに飛ぶ必要があったためその手間を減らしたい。）
動作確認の手順
実際に検索を行い、目視で確認した。
UI 変更部分のスクリーンショット
before
after
PR を出す前の確認事項
見てほしいところ・聞きたいことなど
（自分の環境下では大丈夫だったのですが、）検索が遅くなりすぎてないかの確認もお願いしたいです。
Summary by CodeRabbit
New Features
Style
Other