Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Taskfileにfrontendを更新するためのコマンド追加 #1085

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Dec 30, 2024

PR Type

Enhancement


Description

  • Taskfile.ymlに新しいタスクupdate-frontendを追加しました。このタスクはos:update-frontendを呼び出します。
  • 各OS(Darwin, Linux, Windows)に対応するupdate-frontendタスクをそれぞれのTaskfileに追加しました。
  • Unix系システム用のTaskfileでは、Docker Composeを使用してcollection-proxyサービスをキャッシュなしで再ビルドするコマンドを追加しました。
  • Windows用のTaskfileにも同様のcollection-proxyサービス再ビルドコマンドを追加しました。

Changes walkthrough 📝

Relevant files
Enhancement
Taskfile.yml
Add `update-frontend` task to Taskfile                                     

Taskfile.yml

  • Added a new task update-frontend to the Taskfile.
  • The new task calls os:update-frontend.
  • +5/-1     
    Taskfile_darwin.yml
    Add `update-frontend` task for Darwin                                       

    task/Taskfile_darwin.yml

  • Added a new task update-frontend specific to Darwin (macOS).
  • The task calls unix:update-frontend.
  • +4/-0     
    Taskfile_linux.yml
    Add `update-frontend` task for Linux                                         

    task/Taskfile_linux.yml

  • Added a new task update-frontend specific to Linux.
  • The task calls unix:update-frontend.
  • +5/-1     
    Taskfile_unix.yml
    Add `update-frontend` task for Unix systems                           

    task/Taskfile_unix.yml

  • Added a new task update-frontend for Unix-based systems.
  • The task rebuilds the collection-proxy service using Docker Compose
    with --no-cache.
  • +6/-1     
    Taskfile_windows.yml
    Add `update-frontend` task for Windows                                     

    task/Taskfile_windows.yml

  • Added a new task update-frontend specific to Windows.
  • The task rebuilds the collection-proxy service using Docker Compose
    with --no-cache.
  • +6/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consistency Check

    Ensure that the update-frontend task is consistently implemented across all OS-specific Taskfiles and that the commands are correctly aligned with their respective environments.

    update-frontend:
      cmds:
        - task: os:update-frontend
    Docker Command Validation

    Verify that the docker compose command for rebuilding the collection-proxy service works as intended without caching, especially in Unix environments.

    update-frontend:
      dir: ../
      cmds:
        - docker compose -f docker/dev/compose.yaml build --no-cache collection-proxy

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    codecov bot commented Dec 30, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 49.85%. Comparing base (d259446) to head (e41d728).
    Report is 2 commits behind head on main.

    Additional details and impacted files
    @@           Coverage Diff           @@
    ##             main    #1085   +/-   ##
    =======================================
      Coverage   49.85%   49.85%           
    =======================================
      Files         121      121           
      Lines       10986    10986           
    =======================================
      Hits         5477     5477           
      Misses       5171     5171           
      Partials      338      338           

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    @ikura-hamu ikura-hamu merged commit 8d846d7 into main Dec 30, 2024
    11 checks passed
    @ikura-hamu ikura-hamu deleted the conf/task_update_frontend branch December 30, 2024 12:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant