fix: fix docker exec zombies #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzchaoo
force-pushed
the
fix_docker_exec_zombies
branch
from
28c5397 to
5881f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
We previously used timeout to wrap the command to be executed to prevent the command from hanging and not exiting due to various reasons.
However, it was found that in Alpine-based containers, if process 1 does not have the ability to recycle zombie processes, timeout will cause zombie processes to be generated.
Eventually causing the container to OOM.
Therefore, we need to add detection logic and use timeout to wrap the command to be executed only when ensuring that the target container has the ability to recycle zombie processes.
What changes are included in this PR?
Are there any user-facing changes?
How does this change test