Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trace guide #591

Closed
wants to merge 1 commit into from
Closed

feat: trace guide #591

wants to merge 1 commit into from

Conversation

sw1136562366
Copy link
Contributor

@sw1136562366 sw1136562366 commented Aug 8, 2023 •
edited
Loading

Which issue does this PR close?

Closes #

Rationale for this change

This modification is to make some extensions to the trace access wizard interface

  • Extend apikey to support adding custom tags to span
  • Support apikey to encrypt symmetrically with AES
trace-auth-encrypt:
 enable: true
 secretKey: xx
 iv: xx

What changes are included in this PR?

Are there any user-facing changes?

How does this change test

xzchaoo
xzchaoo approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@xzchaoo xzchaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xzchaoo
xzchaoo requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@xzchaoo xzchaoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix commit history

@sw1136562366 sw1136562366 enabled auto-merge (squash) August 9, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzchaoo xzchaoo xzchaoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sw1136562366 @xzchaoo