Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trace dynamic config #617

Merged

Conversation

sw1136562366
Copy link
Contributor

Which issue does this PR close?

Closes #614
LINK Holoinsight Collector PR

Rationale for this change

The data flow is as follows:

  • trace agent configuration from page ->(push)-> table trace_agent_configuration
  • agent ->(pull)-> Holoinsight collector ->(pull)-> Holoinsight gateway ->(pull)-> cache ->(pull)->table trace_agent_configuration

The trace agent configuration is added to the page and stored in the table trace_agent_configuration, the gateway provides a configuration query interface to the holoinsight collector, the holoinsight gateway has a configuration cache, and the cache is updated every 30 seconds.

What changes are included in this PR?

  • add table trace_agent_configuration_properties for store the trace agent configuration metadata
  • add table trace_agent_configuration for store the trace agent configuration from the page

Are there any user-facing changes?

How does this change test

Copy link
Collaborator

@jsy1001de jsy1001de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sw1136562366 sw1136562366 merged commit a0efdfd into traas-stack:main Aug 18, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace configuration dynamic delivery
2 participants