Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support discarding intermediate data when aggtask is updated #818

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

xzchaoo
Copy link
Contributor

@xzchaoo xzchaoo commented Mar 13, 2024

Which issue does this PR close?

Closes #

Rationale for this change

What changes are included in this PR?

When an AggTask update is found, discard the intermediate calculation results of
the current cycle. Doing so allows you to immediately update the day-level tasks instead of
waiting until the next day to take effect. But the disadvantage is that the intermediate
state will be lost and the data will be calculated from zero.

Are there any user-facing changes?

How does this change test

@xzchaoo xzchaoo requested a review from masaimu March 13, 2024 06:39
@xzchaoo xzchaoo self-assigned this Mar 13, 2024
Copy link
Collaborator

@masaimu masaimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masaimu masaimu merged commit 759cc69 into traas-stack:main Mar 13, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants