Skip to content

Add device attribute to disable forwarding of events for device #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mivtdole wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add device attribute to disable forwarding of events for device #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8c293e
Add device attribute to disable forwarding of events for a specific d…
Jun 19, 2024
4cffeab
Change to global config and attributes per device for position and ev…
Jun 27, 2024
9ff012b
Changes after conversation
Jun 28, 2024
83be58b
Remove Dutch translation
Jun 28, 2024
5bc825c
Rename attribute background name to be same as enableEventForwarding
Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/attributes/useDeviceAttributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,12 @@ export default (t) => useMemo(() => ({
name: t('attributeDeviceInactivityPeriod'),
type: 'number',
},
enablePositionForwarding: {
name: t('attributeDeviceAllowPositionForwarding'),
type: 'boolean',
},
enableEventForwarding: {
name: t('attributeDeviceAllowEventForwarding'),
type: 'boolean',
},
}), [t]);
2 changes: 2 additions & 0 deletions src/resources/l10n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@
"attributeDeviceImage": "Device Image",
"attributeDeviceInactivityStart": "Device Inactivity Start",
"attributeDeviceInactivityPeriod": "Device Inactivity Period",
"attributeDeviceAllowPositionForwarding": "Forward Device Positions",
"attributeDeviceAllowEventForwarding": "Forward Device Events",
Comment on lines +134 to +135
Copy link
Member

@tananaev tananaev Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it here as well. And the test should probably match.

"attributeProcessingCopyAttributes": "Processing: Copy Attributes",
"attributeColor": "Color",
"attributeWebLiveRouteLength": "Web: Live Route Length",
Expand Down