Skip to content

Conversation

@harshanasrimal
Copy link
Contributor

This PR fixes printing functionality issues in the Report section.

Changes

  • Print option only showed the visible preview and now the full report (including scrollable content) is printed.

  • Action button menu appeared in report pdf and its hidden by this PR.

Users can now print/export the entire report in a professional format.

@harshanasrimal
Copy link
Contributor Author

@tananaev now you can review the code again. The only thing is, still there is no option to close the menu before browser print triggers. As I can see, the only thing that we can do is hide it from css. please let me know if you want me to drop it from this PR. Or else if you have a better code suggestion, please let me know

}

@media print {
body, .root {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why both root and body?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shit. sometimes auto complete is annoying. let me fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed another issue while rendering long reports. I think few more divs need to change the height. will try to figure out the actual div.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tananaev I made the changes you requested but I noticed above issue. I tried to figure out the elements that causes to the issue but I failed.

Somehow, applying overflow: visible !important; to all the elements fix the issue, which means there must be another element causing the issue. As It's month end, I'm bit busy. Could you please give a try?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it for later. It's not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants