-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix: Print complete report instead single page #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: Print complete report instead single page #1485
Conversation
|
@tananaev now you can review the code again. The only thing is, still there is no option to close the menu before browser print triggers. As I can see, the only thing that we can do is hide it from css. please let me know if you want me to drop it from this PR. Or else if you have a better code suggestion, please let me know |
public/styles.css
Outdated
| } | ||
|
|
||
| @media print { | ||
| body, .root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why both root and body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh shit. sometimes auto complete is annoying. let me fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tananaev I made the changes you requested but I noticed above issue. I tried to figure out the elements that causes to the issue but I failed.
Somehow, applying overflow: visible !important; to all the elements fix the issue, which means there must be another element causing the issue. As It's month end, I'm bit busy. Could you please give a try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave it for later. It's not urgent.

This PR fixes printing functionality issues in the Report section.
Changes
Print option only showed the visible preview and now the full report (including scrollable content) is printed.
Action button menu appeared in report pdf and its hidden by this PR.
Users can now print/export the entire report in a professional format.