Skip to content

Fix: Browser tab title not updating from server attributes #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spooky-bat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Browser tab title not updating from server attributes #1648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/ServerProvider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,27 @@ const ServerProvider = ({
const [error, setError] = useState(null);

useEffectAsync(async () => {
if (!error) {
try {
const response = await fetch('/api/server');
if (response.ok) {
dispatch(sessionActions.updateServer(await response.json()));
} else {
const message = await response.text();
throw Error(message || response.statusText);
if (!error) {
try {
const response = await fetch('/api/server');
if (response.ok) {
const server = await response.json();
dispatch(sessionActions.updateServer(server));
// Set the page title based on the server attribute configuration (fixes ${title} in index.html)
try {
const title = server.title || server.attributes?.title || server.attributes?.name;
if (title) document.title = title;
} catch (e) {
// Silently ignore errors related to document title update
}
} else {
const message = await response.text();
throw Error(message || response.statusText);
}
} catch (error) {
setError(error.message);
}
} catch (error) {
setError(error.message);
}
}
}, [error]);

if (error) {
Expand Down