Some small fixes #1674
Open
Some small fixes #1674
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Jan 29, 2026
| {!readonly && <MenuItem onClick={handleGeofence}>{t('sharedCreateGeofence')}</MenuItem>} | ||
| <MenuItem component="a" target="_blank" href={`https://www.google.com/maps/search/?api=1&query=${position.latitude}%2C${position.longitude}`}>{t('linkGoogleMaps')}</MenuItem> | ||
| <MenuItem component="a" target="_blank" href={`http://maps.apple.com/?ll=${position.latitude},${position.longitude}`}>{t('linkAppleMaps')}</MenuItem> | ||
| <MenuItem component="a" target="_blank" href={`https://maps.apple.com/?ll=${position.latitude},${position.longitude}`}>{t('linkAppleMaps')}</MenuItem> |
Member
There was a problem hiding this comment.
Is this correctly intercepted on iOS?
Contributor
Author
There was a problem hiding this comment.
On an iphone with IOS26, when entering something like "https://maps.apple.com/?ll=37.7749,-122.4194" in safari, it proposes to open in apple maps.
tananaev
reviewed
Jan 29, 2026
| .replaceAll('\n', '<br>') | ||
| .replaceAll(' ', ' '); | ||
| return ( | ||
| <Alert severity="error"> |
Member
There was a problem hiding this comment.
Can we do something like this instead?
if (error) {
return (
<Alert severity="error">
<code style={{ whiteSpace: 'pre-wrap' }}>
{error.stack}
</code>
</Alert>
);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.