[#108] Inject RetryWire.class into RtGithub#122
Open
HlibYasieniev wants to merge 3 commits intotracehubpm:masterfrom
Open
[#108] Inject RetryWire.class into RtGithub#122HlibYasieniev wants to merge 3 commits intotracehubpm:masterfrom
HlibYasieniev wants to merge 3 commits intotracehubpm:masterfrom
Conversation
h1alexbel
reviewed
May 29, 2024
h1alexbel
left a comment
There was a problem hiding this comment.
@YasenevGleb thank you for this pull request. Looks good. However incoming pull requests still will be failed, due to bad credentials error, like in this case.
Let's make sure that simulation job in mvn.yml executes only in master branch. To keep on track that job is green, let's create and issue in case of job failure, take a look at this example, please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@h1alexbel, please take a look.
PR-Codex Overview
This PR inject 'RetryWire' to 'RtGithub' client
Detailed Summary
Please review and provide feedback. Thank you!
PR-Codex overview
This PR focuses on enhancing GitHub API calls in
GhIdentity.javaby adding a retry mechanism for better reliability.Detailed summary
import com.jcabi.http.wire.RetryWire;for retry mechanism.through(RetryWire.class)for improved API call reliability