Access token from identity provider #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
=============================================
+ Coverage 34.30% 50.57% +16.27%
- Complexity 30 40 +10
=============================================
Files 17 17
Lines 172 174 +2
Branches 5 5
=============================================
+ Hits 59 88 +29
+ Misses 112 84 -28
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
h1alexbel
reviewed
Jan 30, 2024
|
|
||
| @Test | ||
| void invitesCollaboratorSuccessfully() { | ||
| final Github github = Mockito.mock(Github.class); |
There was a problem hiding this comment.
how about using MkGithub here?
Its API is much simpler, take a look:
src/test/java/git/tracehub/pmo/platforms/github/package-info.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Aliaksei Bialiauski <aliaksei.bialiauski@hey.com>
h1alexbel
reviewed
Jan 30, 2024
| ); | ||
| new InviteCollaborator("user/repo", collaborator, github).exec(); | ||
| MatcherAssert.assertThat( | ||
| "Collaborator %s isn't invited".formatted(collaborator), |
There was a problem hiding this comment.
How about Collaborator %s isn't invited as expected ?
h1alexbel
approved these changes
Jan 31, 2024
|
@rultor merge |
@h1alexbel Thanks for your request; @hizmailovich please confirm this. |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on adding functionality to invite collaborators to a GitHub repository.
Detailed summary
InviteCollaboratorclass to invite collaborators to a GitHub repositoryProjectControllerto useInviteCollaboratorto invite collaboratorsInviteCollaboratorclasspom.xmlrealm.jsonIdpTokenclass to retrieve token from IDPIdpTokenclass