Tickets #43

dukris · 2024-02-08T15:54:28Z

@h1alexbel take a look, please
Closes #34
Closes #11
Closes #47

PR-Codex overview

This PR focuses on renaming tables and columns in the database schema. It also includes changes related to projects, tickets, and requests.

Detailed summary

Renamed projects.projects table to projects.project
Renamed projects.performers table to projects.performer
Renamed Projects.byUser method parameter from email to login
Added Projects.employ method with Scalar<Project> parameter
Added Projects.byId method with UUID parameter
Updated SQL queries in various files
Added new JSON data files for project, ticket, and request
Updated test classes and resources
Added new package-info files

The following files were skipped due to too many changes: src/main/resources/db/changelog/2024/004-performers-naming.sql, src/main/resources/sql/insert-ticket.sql, src/main/resources/db/changelog/2024/003-naming.sql, src/main/java/git/tracehub/pmo/platforms/Platform.java, src/main/java/git/tracehub/pmo/security/ExistsRole.java, src/main/java/git/tracehub/pmo/controller/request/RqProject.java, src/main/java/git/tracehub/pmo/project/Project.java, src/main/java/git/tracehub/pmo/controller/request/TicketFromReq.java, src/main/java/git/tracehub/pmo/controller/request/ProjectFromReq.java, src/main/resources/db/changelog/2024/002-tickets.sql, src/main/java/git/tracehub/pmo/ticket/Tickets.java, src/main/java/git/tracehub/pmo/project/DefaultProjects.java, src/test/java/git/tracehub/pmo/security/ExistsRoleTest.java, src/main/java/git/tracehub/pmo/controller/request/RqTicket.java, src/main/java/git/tracehub/pmo/ticket/TicketOf.java, src/test/java/git/tracehub/pmo/project/MockProject.java, src/test/java/git/tracehub/pmo/request/ProjectFromReqTest.java, src/test/java/git/tracehub/pmo/ticket/MockTicket.java, src/test/java/git/tracehub/pmo/request/TicketFromReqTest.java, src/test/java/it/web/RetrieveProjectByIdITCase.java, src/main/java/git/tracehub/pmo/platforms/github/Github.java, src/main/java/git/tracehub/pmo/ticket/Ticket.java, src/main/java/git/tracehub/pmo/controller/TicketController.java, src/main/java/git/tracehub/pmo/ticket/DefaultTickets.java, src/test/java/git/tracehub/pmo/ticket/TicketOfTest.java, src/test/java/git/tracehub/pmo/controller/ProjectControllerTest.java, src/test/java/it/database/DefaultProjectsIT.java, src/test/java/it/database/DefaultTicketsIT.java, src/test/java/it/web/RetrieveTicketByJobITCase.java, src/test/java/it/web/RetrieveTicketByNumberITCase.java, src/main/java/git/tracehub/pmo/controller/ProjectController.java, src/main/java/git/tracehub/pmo/controller/AdviceController.java, src/test/java/it/web/CreateTicketITCase.java, src/test/java/git/tracehub/pmo/controller/TicketControllerTest.java, src/test/java/git/tracehub/pmo/project/DefaultProjectsTest.java, src/test/java/git/tracehub/pmo/ticket/DefaultTicketsTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

codecov · 2024-02-08T16:03:11Z

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (fa5ef9e) 60.81% compared to head (cc0964d) 79.18%.

Files	Patch %	Lines
...java/git/tracehub/pmo/platforms/github/Github.java	0.00%	15 Missing ⚠️
.../git/tracehub/pmo/controller/AdviceController.java	45.45%	12 Missing ⚠️
src/main/java/git/tracehub/pmo/ticket/Ticket.java	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master      #43       +/-   ##
=============================================
+ Coverage     60.81%   79.18%   +18.37%     
- Complexity       59      104       +45     
=============================================
  Files            24       34       +10     
  Lines           245      370      +125     
  Branches          7        7               
=============================================
+ Hits            149      293      +144     
+ Misses           92       73       -19     
  Partials          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

h1alexbel

@hizmailovich check my comments, please

src/main/java/git/tracehub/pmo/controller/ProjectController.java

src/main/java/git/tracehub/pmo/controller/TicketController.java

src/main/java/git/tracehub/pmo/project/Project.java

src/main/java/git/tracehub/pmo/ticket/Ticket.java

src/test/java/git/tracehub/pmo/database/JdbcTest.java

h1alexbel

@hizmailovich regarding table naming

src/main/resources/db/changelog/2024/002-tickets.sql

h1alexbel

@hizmailovich take a look at my comments, please

src/main/java/git/tracehub/pmo/controller/ProjectController.java

h1alexbel · 2024-02-13T18:30:10Z

src/main/java/git/tracehub/pmo/platforms/Platform.java

+ *
+ * @since 0.0.0
+ */
+public interface Platform {


the design of this interface is not scalable, since you will add methods when something will be changed. All your methods are operating with 2 params: Scalar<String> token and Scalar<String> location, so first thing you can do is to introduce just one method that does all of that above:

final class Some implements Platform { private final Scalar<String> token; private final Scalar<String> location; void prepare() { // prepare some platform since we have location and token } }

also, I suggest to encapsulate not a location and token but a whole platform itself, like Github -> RtGithub. I think we can something similar with GitLab, Bitbucket and so on

I used that approach to create a map of beans (platforms) to avoid if-else, but your idea looks better.
Regarding platform encapsulation, it's not suitable here, because of CreateWebhook action, which uses http-requests instead of RtGithub, thus we have to encapsulate both location and token

src/main/resources/db/changelog/2024/003-naming.sql

h1alexbel · 2024-02-13T18:33:01Z

src/test/java/git/tracehub/pmo/project/DefaultProjectsTest.java

@@ -153,4 +201,17 @@ void throwsOnCreatingInvalidProject() throws SQLException {
        ).affirm();
    }

+    private void mock(final Project project) throws SQLException {


how about introducing fake project?

I don't need to retrieve a project as a result, I just want to inject this project into result set
But I removed this private method

h1alexbel

@hizmailovich just one comment

h1alexbel · 2024-02-14T18:06:32Z

src/main/java/git/tracehub/pmo/security/WebConfig.java

+     *
+     * @return Map of implemented platforms
+     */
+    @Bean


can we automate this one using collection autowiring in spring?

h1alexbel · 2024-02-15T11:53:47Z

@rultor merge

rultor · 2024-02-15T11:55:22Z

@rultor merge

@h1alexbel Thanks for your request; @hizmailovich please confirm this.

dukris · 2024-02-15T12:30:03Z

@rultor merge

rultor · 2024-02-15T12:32:04Z

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2024-02-15T12:34:51Z

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 3min)

dukris added 13 commits February 7, 2024 15:46

Resolved #11

fe229be

Tickets implemented

c2aeb9d

Fixed script

b05dc41

Tickets fixed

e8799c6

Unit tests added

dd429b7

Unit tests fixed

ee70e9a

String format refactored

e979c80

It tests implemented

ef95fc1

Controller advice added

52a1404

Resolved #34

d465c06

Unit tests for controllers added

e6fe1f7

It tests for database

92cb531

It tests for controllers

dc6907d

dukris added 2 commits February 9, 2024 16:09

AccessDenied exception hanlked

0e52ba8

Tests fixed

f5f4944

dukris requested a review from h1alexbel February 9, 2024 13:25

h1alexbel requested changes Feb 10, 2024

View reviewed changes

h1alexbel requested changes Feb 12, 2024

View reviewed changes

src/main/resources/db/changelog/2024/002-tickets.sql Show resolved Hide resolved

dukris added 3 commits February 13, 2024 13:27

Inheritance removed

4a19165

Constructors fixed

c8a1dcd

Tables renamed

e62950f

dukris requested a review from h1alexbel February 13, 2024 10:54

dukris added 4 commits February 13, 2024 15:47

Token fixed

a853d93

Resolved #16

33f2213

Tests fixed

18650a3

Resolved #47

1628928

h1alexbel requested changes Feb 13, 2024

View reviewed changes

dukris added 2 commits February 14, 2024 11:34

Values passed

c1abcf4

Tests fixed

f0fd18c

dukris added 4 commits February 14, 2024 12:55

Increment fixed

8518ac4

Platform refactored

d3c00d3

Tests fixed

56a718d

Mocked objects moved to new classes

cc5d1f4

dukris requested a review from h1alexbel February 14, 2024 10:57

h1alexbel reviewed Feb 14, 2024

View reviewed changes

Component added

cc0964d

dukris requested a review from h1alexbel February 15, 2024 11:05

h1alexbel approved these changes Feb 15, 2024

View reviewed changes

rultor merged commit cc0964d into master Feb 15, 2024
8 checks passed

dukris deleted the 34 branch February 15, 2024 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tickets #43

Tickets #43

dukris commented Feb 8, 2024 •

edited by pr-codex bot

Loading

codecov bot commented Feb 8, 2024 •

edited

Loading

h1alexbel left a comment

h1alexbel left a comment

h1alexbel left a comment

h1alexbel Feb 13, 2024

dukris Feb 14, 2024

h1alexbel Feb 13, 2024

dukris Feb 14, 2024

h1alexbel left a comment

h1alexbel Feb 14, 2024

h1alexbel commented Feb 15, 2024

rultor commented Feb 15, 2024

dukris commented Feb 15, 2024

rultor commented Feb 15, 2024

rultor commented Feb 15, 2024

Tickets #43

Tickets #43

Conversation

dukris commented Feb 8, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

codecov bot commented Feb 8, 2024 • edited Loading

Codecov Report

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel Feb 13, 2024

Choose a reason for hiding this comment

dukris Feb 14, 2024

Choose a reason for hiding this comment

h1alexbel Feb 13, 2024

Choose a reason for hiding this comment

dukris Feb 14, 2024

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel Feb 14, 2024

Choose a reason for hiding this comment

h1alexbel commented Feb 15, 2024

rultor commented Feb 15, 2024

dukris commented Feb 15, 2024

rultor commented Feb 15, 2024

rultor commented Feb 15, 2024

dukris commented Feb 8, 2024 •

edited by pr-codex bot

Loading

codecov bot commented Feb 8, 2024 •

edited

Loading