Secrets API #48
Merged
Secrets API #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
============================================
+ Coverage 79.18% 82.00% +2.81%
- Complexity 104 134 +30
============================================
Files 34 44 +10
Lines 370 439 +69
Branches 7 8 +1
============================================
+ Hits 293 360 +67
- Misses 73 74 +1
- Partials 4 5 +1 ☔ View full report in Codecov by Sentry. |
h1alexbel
requested changes
Feb 16, 2024
h1alexbel
reviewed
Feb 20, 2024
| final ResourceAlreadyExistsException exception | ||
| ) { | ||
| log.warn(exception.getMessage(), exception); | ||
| return new ResponseEntity<>( |
There was a problem hiding this comment.
lets create a new class RestError that encapsulate the status and returns a Json document. This can help us to resolve code duplication. WDYT?
| @RequestParam final UUID project, | ||
| @RequestParam final String key | ||
| ) { | ||
| return this.secrets.value(project, key); | ||
| } |
There was a problem hiding this comment.
we also should have an endpoint that returns a list of keys for secrets in the project. Lets create a puzzle for now
h1alexbel
reviewed
Feb 20, 2024
| @@ -36,6 +36,8 @@ | |||
| /** | |||
| * Secret Controller. | |||
| * | |||
| * @todo #44:30min create an endpoint to list all secrets from the project. | |||
There was a problem hiding this comment.
We should list their keys only
h1alexbel
approved these changes
Feb 20, 2024
|
@rultor merge |
@h1alexbel Thanks for your request; @hizmailovich please confirm this. |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@h1alexbel take a look, please
Closes #44
PR-Codex overview
This PR updates package names, adds secret-related functionality, and improves exception handling.
Detailed summary
requesttocontroller.requestSecretentity, controller, and SQL schemaRqSecretrequest recordResourceAlreadyExistsExceptionexception class