Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping for querying tickets #57

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Mapping for querying tickets #57

merged 2 commits into from
Feb 27, 2024

Conversation

dukris
Copy link
Collaborator

@dukris dukris commented Feb 26, 2024

@h1alexbel take a look, please
Closes #54


PR-Codex overview

The focus of this PR is to enhance error handling in controllers and improve request parameter validation.

Detailed summary

  • Added exception handling for IllegalArgumentException in AdviceController
  • Updated TicketController to handle optional request parameters for job and number
  • Added tests for error responses in RetrieveTicketByJobITCase and RetrieveTicketByNumberITCase
  • Added test for empty request parameters in TicketControllerTest

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@dukris dukris requested a review from h1alexbel February 26, 2024 16:11
@h1alexbel
Copy link
Collaborator

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Feb 26, 2024

@rultor try to merge

@h1alexbel Thanks for your request; @hizmailovich please confirm this.

@dukris
Copy link
Collaborator Author

dukris commented Feb 27, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 27, 2024

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 45dca56 into master Feb 27, 2024
6 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 27, 2024

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 3min)

@dukris dukris deleted the 54 branch February 27, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default get mapping for quering ticket by number
3 participants