OAuth2 Github client #7

dukris · 2024-01-15T14:30:34Z

Closes #9

PR-Codex overview

This PR focuses on adding new files and making changes related to database configuration, licensing, and code comments.

Detailed summary

Added ANALYZE my_table to analyze.sql
Added db/changelog/2024 to db.changelog-master.yaml
Added database configuration to application-pgit.yaml and application.yaml
Updated LICENSE.txt and package-info.java files with .git extension
Added SQL insert statements to projects.sql
Updated port number in application.yaml
Added Docker Compose configuration in docker-compose.yml
Updated code comments in Java files

The following files were skipped due to too many changes: src/main/resources/sql/select-project-by-id.sql, src/test/java/git/tracehub/pmo/security/package-info.java, src/main/java/git/tracehub/pmo/controller/package-info.java, src/test/java/git/tracehub/pmo/platforms/package-info.java, src/main/java/git/tracehub/pmo/platforms/github/package-info.java, src/main/java/git/tracehub/pmo/project/Sql.java, src/main/java/git/tracehub/pmo/platforms/Action.java, src/main/resources/sql/insert-project.sql, src/main/resources/sql/select-projects-by-user-email.sql, src/main/java/git/tracehub/pmo/exception/ResourceNotFoundException.java, src/main/java/git/tracehub/pmo/project/DateOf.java, src/main/java/git/tracehub/pmo/platforms/RepoPath.java, src/main/java/git/tracehub/pmo/security/ClaimOf.java, src/test/java/git/tracehub/pmo/platforms/RepoPathTest.java, src/main/java/git/tracehub/pmo/project/Project.java, src/main/java/git/tracehub/pmo/project/Projects.java, src/test/java/git/tracehub/pmo/project/SqlStatementTest.java, src/main/java/git/tracehub/pmo/project/AdjustedText.java, src/main/java/git/tracehub/pmo/security/ExistsRole.java, src/main/java/git/tracehub/pmo/project/ProjectOf.java, src/test/java/git/tracehub/pmo/project/DateOfTest.java, src/test/java/git/tracehub/pmo/project/AdjustedTextTest.java, src/main/java/git/tracehub/pmo/project/SqlStatement.java, src/main/java/git/tracehub/pmo/platforms/github/InviteCollaborator.java, src/main/resources/db/changelog/2024/001-projects.sql, src/test/java/git/tracehub/pmo/security/ClaimOfTest.java, src/test/java/git/tracehub/pmo/security/ExistsRoleTest.java, src/test/java/it/KeycloakIntegration.java, src/test/java/it/PostgresIntegration.java, src/test/java/it/web/KeycloakToken.java, src/main/java/git/tracehub/pmo/security/IdpToken.java, src/test/java/git/tracehub/pmo/project/ProjectOfTest.java, src/main/java/git/tracehub/pmo/project/DefaultProjects.java, src/test/java/it/web/RetrieveProjectsByUserITCase.java, src/test/java/it/web/RetrieveProjectByIdITCase.java, src/main/java/git/tracehub/pmo/security/SecurityConfig.java, src/main/java/git/tracehub/pmo/controller/ProjectController.java, pom.xml, src/test/resources/data/realm.json, realm-export.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

codecov · 2024-01-17T15:05:44Z

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

h1alexbel

@hizmailovich take a look, at my comments

pom.xml

src/main/java/git/tracehub/pmo/agents/Action.java

src/main/java/git/tracehub/pmo/agents/github/InviteCollaborator.java

src/main/java/git/tracehub/pmo/exception/ResourceNotFoundException.java

src/main/java/git/tracehub/pmo/security/ClaimOf.java

src/main/resources/application.yaml

h1alexbel

@hizmailovich just a few small comments

src/main/java/git/tracehub/pmo/agents/github/InviteCollaborator.java

src/test/java/it/web/Token.java

h1alexbel

@hizmailovich take a look at my comments, please

h1alexbel · 2024-01-23T10:50:04Z

src/main/java/git/tracehub/pmo/agents/RepoPath.java

+ * SOFTWARE.
+ */
+
+package git.tracehub.pmo.agents;


I don't think this logic is related to agents, this name its very abstract, names
like github, gitlab, bitbucket will be more suitable here.

see the point?

This logic related to all agents, that's why RepoPath is located here, but this package also includes such packages as github, gitlab, and bitbucket

@hizmailovich
My comment was related to problem that these objects are not agents, here you are making some actions with operators/target platforms like GitHub, GitLab and so on.
So I propose to stay with package naming that includes just a platform name. Its a good idea to group so-called agents, but agents are not the best name here, I believe.

Renamed to platforms

src/test/java/it/web/AccessToken.java

h1alexbel

@hizmailovich one comment on real-export.json

h1alexbel · 2024-01-23T10:58:39Z

imports/realm-export.json

Do we really need this?

I think if it some secret that must be present at application runtime, lets move it from this repo to secrets

This file just contains of the information about realm without any sensitive data, moreover we need this file in such location to use it in docker-compose
what do you think?

@hizmailovich place it inside root then

h1alexbel · 2024-01-23T10:59:59Z

@hizmailovich sorry for double review here.
I missed realm-export.json file.

h1alexbel

@hizmailovich commit look good, answered on your questions, see above

h1alexbel

@hizmailovich good one

h1alexbel · 2024-01-23T14:07:47Z

@rultor try to merge

dukris · 2024-01-23T14:13:23Z

@rultor merge

rultor · 2024-01-23T14:15:37Z

@rultor try to merge

@h1alexbel Thanks for your request; @hizmailovich please confirm this.

rultor · 2024-01-23T14:16:59Z

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2024-01-23T14:22:57Z

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 5min)

dukris added 10 commits January 15, 2024 17:29

Github oauth2 client

6d3c574

Liquibase connected

983e7e6

Projects added

14770b5

Tests added

7e9862c

Resolved #9

bb920ed

Token added to header

7afd2a4

Docs fixed

0d310b4

Unused file removed

eb8c9ab

MediaType updated

d44582a

Violation fixed

153416a

dukris added 5 commits January 18, 2024 19:06

Resource server configured

3d5d587

Keycloak configured

79462a8

Xcop fixed

2eb0f85

Puzzle created

4890edb

Tests added

ac75d45

dukris requested a review from h1alexbel January 19, 2024 12:56

h1alexbel requested changes Jan 19, 2024

View reviewed changes

dukris added 9 commits January 19, 2024 18:53

Checkstyle and pmd included

1bc7b55

License fixed

53b7ef8

Unused exception removed

f3c27b0

Type casting removed

f8bad0d

Tests fixed

19e768c

Unnecessary import removed

53ebb95

Jcabi github added

7dc3719

Integration tests added

ed82252

Http status added

df49bbf

dukris requested a review from h1alexbel January 22, 2024 13:16

Keycloak config added

686df95

h1alexbel reviewed Jan 22, 2024

View reviewed changes

src/main/java/git/tracehub/pmo/agents/github/InviteCollaborator.java Outdated Show resolved Hide resolved

src/test/java/it/web/Token.java Outdated Show resolved Hide resolved

dukris added 4 commits January 23, 2024 10:27

Path moved to a new class

1fdf881

Token renamed to AccessToken

6bbeb9a

Path to repository

677f818

Checkstyle

cbc1452

dukris requested a review from h1alexbel January 23, 2024 08:23

h1alexbel requested changes Jan 23, 2024

View reviewed changes

h1alexbel reviewed Jan 23, 2024

View reviewed changes

Token renamed

65789db

dukris requested a review from h1alexbel January 23, 2024 12:33

h1alexbel reviewed Jan 23, 2024

View reviewed changes

dukris added 2 commits January 23, 2024 16:35

Agents renamed

43bf458

Json moved to root

3a66d6b

h1alexbel approved these changes Jan 23, 2024

View reviewed changes

rultor merged commit ebc419c into master Jan 23, 2024
8 checks passed

h1alexbel deleted the 1 branch January 23, 2024 14:31

h1alexbel restored the 1 branch January 23, 2024 14:31

dukris deleted the 1 branch January 23, 2024 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OAuth2 Github client #7

OAuth2 Github client #7

dukris commented Jan 15, 2024 •

edited by pr-codex bot

Loading

codecov bot commented Jan 17, 2024

h1alexbel left a comment

h1alexbel left a comment

h1alexbel left a comment

h1alexbel Jan 23, 2024

dukris Jan 23, 2024

h1alexbel Jan 23, 2024 •

edited

Loading

dukris Jan 23, 2024

h1alexbel left a comment

h1alexbel Jan 23, 2024

dukris Jan 23, 2024

h1alexbel Jan 23, 2024

h1alexbel commented Jan 23, 2024 •

edited

Loading

h1alexbel left a comment

h1alexbel left a comment

h1alexbel commented Jan 23, 2024

dukris commented Jan 23, 2024

rultor commented Jan 23, 2024

rultor commented Jan 23, 2024

rultor commented Jan 23, 2024

OAuth2 Github client #7

OAuth2 Github client #7

Conversation

dukris commented Jan 15, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

codecov bot commented Jan 17, 2024

Welcome to Codecov 🎉

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel Jan 23, 2024

Choose a reason for hiding this comment

dukris Jan 23, 2024

Choose a reason for hiding this comment

h1alexbel Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

dukris Jan 23, 2024

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel Jan 23, 2024

Choose a reason for hiding this comment

dukris Jan 23, 2024

Choose a reason for hiding this comment

h1alexbel Jan 23, 2024

Choose a reason for hiding this comment

h1alexbel commented Jan 23, 2024 • edited Loading

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel left a comment

Choose a reason for hiding this comment

h1alexbel commented Jan 23, 2024

dukris commented Jan 23, 2024

rultor commented Jan 23, 2024

rultor commented Jan 23, 2024

rultor commented Jan 23, 2024

dukris commented Jan 15, 2024 •

edited by pr-codex bot

Loading

h1alexbel Jan 23, 2024 •

edited

Loading

h1alexbel commented Jan 23, 2024 •

edited

Loading