Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom attributes and constants pipeline2atx (#32) #33

Merged
merged 4 commits into from
Feb 26, 2024
Merged

add custom attributes and constants pipeline2atx (#32) #33

merged 4 commits into from
Feb 26, 2024

Conversation

MxEh-TT
Copy link
Contributor

@MxEh-TT MxEh-TT commented Feb 20, 2024

Closes #32

MxEh-TT and others added 3 commits February 20, 2024 11:23
@MxEh-TT MxEh-TT changed the title add custom attributes and constants pipeline2atx add custom attributes and constants pipeline2atx (#32) Feb 20, 2024
ErikRehmTT
ErikRehmTT requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@ErikRehmTT ErikRehmTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically the remarks should be separate test cases (one for normal env eval, one for overwriting a value, one for adding a new attribute/const)

test/vars/Pipeline2ATXTest.groovy Outdated Show resolved Hide resolved
test/vars/Pipeline2ATXTest.groovy Outdated Show resolved Hide resolved
@tt-marcel tt-marcel merged commit 80d8b0d into main Feb 26, 2024
5 checks passed
@tt-marcel tt-marcel deleted the i32_add-custom-attributes-and-constants-pipeline2atx branch February 26, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikRehmTT ErikRehmTT ErikRehmTT approved these changes

Assignees

@MxEh-TT MxEh-TT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom attributes and constants for pipeline2ATX
3 participants
@MxEh-TT @ErikRehmTT @tt-marcel