Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Replace Extension subclasses #879

Merged
merged 1 commit into from
Aug 29, 2024
Merged

API Replace Extension subclasses #879

merged 1 commit into from
Aug 29, 2024

Conversation

emteknetnz
Copy link
Contributor

@emteknetnz emteknetnz commented Aug 20, 2024 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Aug 20, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/8/replace-extension-subclasses branch from 09f3c1a to ced3e6e Compare August 20, 2024 21:23
@emteknetnz emteknetnz force-pushed the pulls/8/replace-extension-subclasses branch from ced3e6e to 810989b Compare August 28, 2024 02:28
@tractorcow
Copy link
Collaborator

Sure, if that's what the new silverstripe has changed, sounds good to me.

GuySartorelli
GuySartorelli reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will hold this one off for last since it has failing tests. Will rerun CI after everything else is merged.

@GuySartorelli
Copy link
Contributor

CI still failing - I would have said these look unrelated, except the full kitchen sink run was passing so I'd expect this to pass now too.

@emteknetnz emteknetnz force-pushed the pulls/8/replace-extension-subclasses branch from 810989b to 7b886fb Compare August 29, 2024 06:22
@emteknetnz
Copy link
Contributor Author

Have updated unit test to use an equivalent public API

@emteknetnz emteknetnz force-pushed the pulls/8/replace-extension-subclasses branch from 7b886fb to d9c90f9 Compare August 29, 2024 06:26
GuySartorelli
GuySartorelli approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 72e2fa6 into tractorcow-farm:8 Aug 29, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/8/replace-extension-subclasses branch August 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tractorcow tractorcow tractorcow approved these changes

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @tractorcow @GuySartorelli