Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #895

Merged
merged 1 commit into from
Sep 30, 2024
Merged

MNT Fix unit test #895

merged 1 commit into from
Sep 30, 2024

Conversation

GuySartorelli
Copy link
Contributor

@GuySartorelli GuySartorelli commented Sep 30, 2024 •
edited
Loading

Fixes https://github.com/tractorcow-farm/silverstripe-fluent/actions/runs/11061583426/job/30734490014

TractorCow\Fluent\Tests\Model\LocalDateTimeTest::testSwitchLocales with data set #0 ('en_NZ', '2021-01-13 02:00:12')
Error: Unknown named parameter $localTIme

and

TractorCow\Fluent\Tests\Task\InitialPageLocalisationTaskTest::testInitialPageLocalisation with data set #0 (false, 0, ['Page1', 'Page2', 'Page3', 'Page4'], [])
Symfony\Component\Console\Exception\InvalidArgumentException: The "publish" option does not exist.

Issue

@GuySartorelli GuySartorelli marked this pull request as draft September 30, 2024 01:54
@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
Open
@GuySartorelli GuySartorelli marked this pull request as ready for review September 30, 2024 02:04
@tractorcow
Copy link
Collaborator

Feel free to merge at your convenience.

@emteknetnz emteknetnz merged commit fdec5ba into tractorcow-farm:8 Sep 30, 2024
8 checks passed
@emteknetnz emteknetnz deleted the pulls/8/fix-tests branch September 30, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tractorcow tractorcow tractorcow approved these changes

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuySartorelli @tractorcow @emteknetnz