builtin: Obliterate empty definition of dialect types.

trailofbits · Mar 12, 2024 · 1cff1d9 · 1cff1d9
1 parent 698a3e8
commit 1cff1d9
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 66 deletions.
diff --git a/include/vast/Dialect/Builtin/Builtin.td b/include/vast/Dialect/Builtin/Builtin.td
@@ -21,19 +21,12 @@ def Builtin_Dialect : Dialect {
     TODO
   }];
 
-  let extraClassDeclaration = [{
-      void registerTypes();
-  }];
-
-  let useDefaultTypePrinterParser = 1;
-
   let hasConstantMaterializer = 1;
 }
 
 class Builtin_Op< string mnemonic, list< Trait > traits = [] >
   : Op< Builtin_Dialect, mnemonic, traits >;
 
-include "vast/Dialect/Builtin/Types.td"
 include "vast/Dialect/Builtin/Ops.td"
 
 #endif // VAST_DIALECT_BUILTIN
diff --git a/include/vast/Dialect/Builtin/Ops.hpp b/include/vast/Dialect/Builtin/Ops.hpp
@@ -11,7 +11,6 @@ VAST_RELAX_WARNINGS
 VAST_UNRELAX_WARNINGS
 
 #include "vast/Dialect/Builtin/Dialect.hpp"
-#include "vast/Dialect/Builtin/Types.hpp"
 #include "vast/Util/Common.hpp"
 
 #define GET_OP_CLASSES

diff --git a/include/vast/Dialect/Builtin/Types.hpp b/include/vast/Dialect/Builtin/Types.hpp
diff --git a/include/vast/Dialect/Builtin/Types.td b/include/vast/Dialect/Builtin/Types.td
diff --git a/lib/vast/Dialect/Builtin/CMakeLists.txt b/lib/vast/Dialect/Builtin/CMakeLists.txt
@@ -2,5 +2,4 @@
 add_vast_dialect_library(Builtin
     Dialect.cpp
     Ops.cpp
-    Types.cpp
 )
diff --git a/lib/vast/Dialect/Builtin/Dialect.cpp b/lib/vast/Dialect/Builtin/Dialect.cpp
@@ -2,7 +2,6 @@
 //
 #include "vast/Dialect/Builtin/Dialect.hpp"
 #include "vast/Dialect/Builtin/Ops.hpp"
-#include "vast/Dialect/Builtin/Types.hpp"
 
 #include <mlir/IR/Builders.h>
 #include <mlir/IR/DialectImplementation.h>
@@ -14,8 +13,6 @@ namespace vast::hlbi {
     using OpBuilder = mlir::OpBuilder;
 
     void BuiltinDialect::initialize() {
-        registerTypes();
-
         addOperations<
 #define GET_OP_LIST
 #include "vast/Dialect/Builtin/Builtin.cpp.inc"

diff --git a/lib/vast/Dialect/Builtin/Ops.cpp b/lib/vast/Dialect/Builtin/Ops.cpp
@@ -18,7 +18,6 @@ VAST_UNRELAX_WARNINGS
 
 #include "vast/Dialect/Builtin/Dialect.hpp"
 #include "vast/Dialect/Builtin/Ops.hpp"
-#include "vast/Dialect/Builtin/Types.hpp"
 
 using namespace vast::hlbi;
 

diff --git a/lib/vast/Dialect/Builtin/Types.cpp b/lib/vast/Dialect/Builtin/Types.cpp