core: Fix linkage type of function declarations.

trailofbits · Oct 26, 2023 · 3cf766b · 3cf766b
1 parent c843a5e
commit 3cf766b
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/vast/Dialect/Core/Linkage.cpp b/lib/vast/Dialect/Core/Linkage.cpp
@@ -162,19 +162,24 @@ namespace vast::core {
             return GlobalLinkageKind::InternalLinkage;
         }
 
+        if (const auto *fn = decl->getAsFunction()) {
+            if (fn->isMultiVersion() && linkage == clang::GVA_AvailableExternally) {
+                return GlobalLinkageKind::LinkOnceAnyLinkage;
+            }
+            if (!fn->isThisDeclarationADefinition()
+                && decl->hasAttr< clang::WeakAttr >())
+            {
+                return GlobalLinkageKind::ExternalWeakLinkage;
+            }
+        }
+
         if (decl->hasAttr< clang::WeakAttr >()) {
             if (is_constant)
                 return GlobalLinkageKind::WeakODRLinkage;
             else
                 return GlobalLinkageKind::WeakAnyLinkage;
         }
 
-        if (const auto *fn = decl->getAsFunction()) {
-            if (fn->isMultiVersion() && linkage == clang::GVA_AvailableExternally) {
-                return GlobalLinkageKind::LinkOnceAnyLinkage;
-            }
-        }
-
         // We are guaranteed to have a strong definition somewhere else,
         // so we can use available_externally linkage.
         if (linkage == clang::GVA_AvailableExternally) {