Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused Definition Elimination #522

Merged
merged 33 commits into from
Mar 11, 2024
Merged

Unused Definition Elimination #522

merged 33 commits into from
Mar 11, 2024

Conversation

xlauko
Copy link
Member

@xlauko xlauko commented Mar 6, 2024

No description provided.

@xlauko xlauko requested a review from lkorenc March 6, 2024 16:15
@xlauko xlauko self-assigned this Mar 6, 2024
@xlauko xlauko marked this pull request as ready for review March 8, 2024 16:20
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 8 file(s) not formatted
  • include/vast/Dialect/HighLevel/HighLevelUtils.hpp
  • include/vast/Frontend/Pipelines.hpp
  • include/vast/Interfaces/AggregateTypeDefinitionInterface.hpp
  • include/vast/Util/Pipeline.hpp
  • include/vast/Util/TypeUtils.hpp
  • include/vast/Util/Warnings.hpp
  • lib/vast/Dialect/HighLevel/Passes.cpp
  • lib/vast/Dialect/HighLevel/Transforms/UDE.cpp
clang-tidy reports: 11 concern(s)
  • include/vast/Interfaces/AggregateTypeDefinitionInterface.hpp:30:10: error: [clang-diagnostic-error]

    'vast/Interfaces/AggregateTypeDefinitionInterface.h.inc' file not found

       30 | #include "vast/Interfaces/AggregateTypeDefinitionInterface.h.inc"
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • include/vast/Util/Pipeline.hpp:107:17: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      107 |         virtual gap::generator< pipeline_step_ptr > substeps() const = 0;
          |                 ^
  • include/vast/Util/Pipeline.hpp:109:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      109 |         gap::generator< pipeline_step_ptr > dependencies() const;
          |         ^
  • include/vast/Util/Pipeline.hpp:131:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      131 |         gap::generator< pipeline_step_ptr > substeps() const override;
          |         ^
  • include/vast/Util/Pipeline.hpp:165:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      165 |         gap::generator< pipeline_step_ptr > substeps() const override;
          |         ^
  • lib/vast/Util/Pipeline.cpp:19:5: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

       19 |     gap::generator< pipeline_step_ptr > pipeline_step::dependencies() const {
          |     ^
  • lib/vast/Util/Pipeline.cpp:21:13: error: [clang-diagnostic-error]

    std::coroutine_traits type was not found; include before defining a coroutine

       21 |             co_yield dep();
          |             ^
  • lib/vast/Util/Pipeline.cpp:25:5: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

       25 |     gap::generator< pipeline_step_ptr > pass_pipeline_step::substeps() const { co_return; }
          |     ^
  • lib/vast/Util/Pipeline.cpp:25:80: error: [clang-diagnostic-error]

    std::coroutine_traits type was not found; include before defining a coroutine

       25 |     gap::generator< pipeline_step_ptr > pass_pipeline_step::substeps() const { co_return; }
          |                                                                                ^
  • lib/vast/Util/Pipeline.cpp:27:5: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

       27 |     gap::generator< pipeline_step_ptr > compound_pipeline_step::substeps() const {
          |     ^
  • lib/vast/Util/Pipeline.cpp:29:13: error: [clang-diagnostic-error]

    std::coroutine_traits type was not found; include before defining a coroutine

       29 |             co_yield step();
          |             ^

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 9e5e480 into master Mar 11, 2024
8 checks passed
@xlauko xlauko deleted the desugar-pass branch March 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants