Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maybe parse op #761

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions include/vast/Dialect/Parser/Ops.td
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ def Parse_NoParse
}];
}

def Parse_MaybeParse
: Parser_Op< "maybeparse" >
, Arguments< (ins Variadic<Parser_AnyDataType>:$arguments) >
, Results< (outs Variadic<Parser_AnyDataType>:$result) >
{
let summary = "Maybe parsing operation data.";

let assemblyFormat = [{
$arguments attr-dict `:` functional-type($arguments, $result)
}];
}

def Parse_ToMaybe
: Parser_Op< "to_maybe" >
, Arguments< (ins Parser_AnyDataType:$arguments) >
Expand Down
69 changes: 68 additions & 1 deletion lib/vast/Conversion/Parser/ToParser.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

Check notice on line 1 in lib/vast/Conversion/Parser/ToParser.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter (19, 22.04)

Run clang-format on lib/vast/Conversion/Parser/ToParser.cpp

File lib/vast/Conversion/Parser/ToParser.cpp does not conform to Custom style guidelines. (lines 238, 257, 267, 268, 350, 352, 353, 354, 355, 357)
#include "vast/Util/Warnings.hpp"

#include "vast/Conversion/Parser/Passes.hpp"
Expand Down Expand Up @@ -232,8 +232,10 @@
).getResult(0);
}

using value_range = mlir::ValueRange;

std::vector< mlir_value > convert_value_types(
mlir::ValueRange values, mlir::TypeRange types, auto &rewriter
value_range values, mlir::TypeRange types, auto &rewriter
) {
std::vector< mlir_value > out;
out.reserve(values.size());
Expand All @@ -248,6 +250,33 @@
return out;
}

std::vector< mlir_value > realized_operand_values(value_range values) {
std::vector< mlir_value > out;
out.reserve(values.size());
for (auto val : values) {
if (auto cast = mlir::dyn_cast< mlir::UnrealizedConversionCastOp >(val.getDefiningOp())) {
out.push_back(cast.getOperand(0));
} else {
out.push_back(val);
}
}
return out;
}

mlir_type join(mlir_type lhs, mlir_type rhs) {
if (!lhs)
return rhs;
return lhs == rhs ? lhs : pr::MaybeDataType::get(lhs.getContext());
}

mlir_type top_type(value_range values) {
mlir_type ty;
for (auto val : values) {
ty = join(ty, val.getType());
}
return ty;
}

template< typename op_t >
struct parser_conversion_pattern_base
: mlir_pattern_mixin< operation_conversion_pattern< op_t > >
Expand Down Expand Up @@ -306,6 +335,42 @@
}
};

template< typename op_t >
struct ToMaybeParse : operation_conversion_pattern< op_t >
{
using base = operation_conversion_pattern< op_t >;
using base::base;

using adaptor_t = typename op_t::Adaptor;

logical_result matchAndRewrite(
op_t op, adaptor_t adaptor, conversion_rewriter &rewriter
) const override {
auto args = realized_operand_values(adaptor.getOperands());
auto rty = top_type(args);

auto converted = [&] () -> operation {
auto matches_return_type = [rty] (auto val) { return val.getType() == rty; };
if (mlir::isa< pr::NoDataType >(rty) && llvm::all_of(args, matches_return_type))
return rewriter.create< pr::NoParse >(op.getLoc(), rty, args);
return rewriter.create< pr::MaybeParse >(op.getLoc(), rty, args);
} ();

rewriter.replaceOpWithNewOp< mlir::UnrealizedConversionCastOp >(
op, op.getType(), converted->getResult(0)
);

return mlir::success();
}

static void legalize(parser_conversion_config &cfg) {
cfg.target.addLegalOp< pr::MaybeParse >();
cfg.target.addLegalOp< pr::NoParse >();
cfg.target.addLegalOp< mlir::UnrealizedConversionCastOp >();
cfg.target.addIllegalOp< op_t >();
}
};

struct CallConversion : parser_conversion_pattern_base< hl::CallOp >
{
using op_t = hl::CallOp;
Expand Down Expand Up @@ -572,6 +637,8 @@
ToNoParse< hl::ImplicitCastOp >,
ToNoParse< hl::CmpOp >, ToNoParse< hl::FCmpOp >,
// Integer arithmetic
ToMaybeParse< hl::AddIOp >, ToMaybeParse< hl::SubIOp >,
// Non-parsing integer arithmetic operations
ToNoParse< hl::MulIOp >,
ToNoParse< hl::DivSOp >, ToNoParse< hl::DivUOp >,
ToNoParse< hl::RemSOp >, ToNoParse< hl::RemUOp >,
Expand Down
Loading