enh: Dynamically implement config to allow transfer from negative balance

app/Http/Controllers/API/v1/TransactionController.php

@@ -274,6 +274,14 @@ public function store(Request $request): JsonResponse
         $data = $validationResult['data'];
         $user = $request->user();
 
+        $wallet = \App\Models\Wallet::find($data['wallet_id']);
+        $allowNegative = $user->getConfigValue('allow-negative-balance', false);
+
+        // Only check for expense types; income is always allowed
+        if ($data['type'] === 'expense' && $wallet->balance < $data['amount'] && !$allowNegative) {
+            return $this->failure(__('Insufficient balance in wallet'), 422);
+        }
+
         if (! empty($data['client_id'])) {
             $existingTransaction = Transaction::findByClientId($data['client_id'], $user);
             if ($existingTransaction) {
@@ -370,6 +378,8 @@ public function store(Request $request): JsonResponse
                     )->delay($recurring_transaction->next_scheduled_at);
                 }
 
+
+
                 return $transaction;
             });
         } catch (HttpException $e) {
@@ -382,7 +392,9 @@ public function store(Request $request): JsonResponse
             return $this->failure(__('Failed to create transaction'), 500, [$e->getMessage()]);
         }
 
-        return $this->success($transaction, statusCode: 201);
+
+        return $this->transferWithNegativeBalance($transaction);
+        // return $this->success($transaction, statusCode: 201);
     }
 
     #[OA\Delete(
@@ -824,4 +836,20 @@ private function validateResourceOwnership(array $data, array $categories = []):
             }
         }
     }
+
+    /**
+     * Helper to format the success response and inject negative balance warnings.
+     */
+    private function transferWithNegativeBalance(Transaction $transaction): JsonResponse
+    {
+        $transaction->load('wallet');
+
+        $responseData = $transaction->toArray();
+
+        if ($transaction->wallet->balance < 0) {
+            $responseData['warning'] = __('Transaction recorded, but your wallet is now in a negative balance.');
+        }
+
+        return $this->success($responseData, statusCode: 201);
+    }
 }

app/Models/User.php

@@ -65,6 +65,20 @@ class User extends Authenticatable
         'password' => 'hashed',
     ];
 
+    /**
+     * The "booted" method of the model.
+     */
+    protected static function booted()
+    {
+        static::created(function ($user) {
+
+            $user->setConfigValue(
+                'allow-negative-balance',
+                false,
+                \Whilesmart\ModelConfiguration\Enums\ConfigValueType::Boolean
+            );
+        });
+    }
     public function categories(): HasMany
     {
         return $this->hasMany(Category::class);

app/Services/TransferService.php

@@ -26,7 +26,11 @@ public function transfer(
         ?string $datetime = null,
         array $transactionClientIds = []
     ) {
-        if ($fromWallet->balance < $amountToSend) {
+        //check the user allows negative balance
+        $allowNegativeBalance = $user->getConfigValue('allow-negative-balance');
+
+        //only throw the exception if the balance is low and they havent enabled negative transfers
+        if ($fromWallet->balance < $amountToSend && !$allowNegativeBalance) {
             throw new InvalidArgumentException(__('Insufficient balance in source wallet'));
         }
 

database/migrations/2025_06_30_120453_create_configurations_table.php

@@ -0,0 +1,33 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class () extends Migration {
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        Schema::create('configurations', function (Blueprint $table) {
+            $table->id();
+            $table->string('key');
+            $table->json('value');
+            $table->string('configurable_type');
+            $table->unsignedBigInteger('configurable_id');
+            $table->string('type')->default('string');
+            $table->timestamps();
+
+            $table->unique(['configurable_id', 'configurable_type', 'key']);
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+        Schema::dropIfExists('configurations');
+    }
+};

database/seeders/ConfigurationSeeder.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Database\Seeders;
+
+use App\Models\User;
+use Illuminate\Database\Seeder;
+use Whilesmart\ModelConfiguration\Enums\ConfigValueType;
+
+class ConfigurationSeeder extends Seeder
+{
+    public function run(): void
+    {
+        $users = User::all();
+
+        foreach ($users as $user) {
+
+            // Ensure the user has "Allow Negative Balance" set to false by default
+            $user->setConfigValue(
+                'allow-negative-balance',
+                false,
+                ConfigValueType::Boolean
+            );
+        }
+    }
+}

database/seeders/DatabaseSeeder.php

@@ -14,6 +14,7 @@ public function run(): void
         $this->call([
             UserSeeder::class,
             TransactionSeeder::class,
+            ConfigurationSeeder::class,
         ]);
     }
 }

phpunit.xml

@@ -26,11 +26,13 @@
         <env name="CACHE_DRIVER" value="array"/>
         <env name="DB_DATABASE" value="trakli_test"/>
         <env name="DB_HOST" value="mysql-test"/>
+
         <env name="MAIL_MAILER" value="array"/>
         <env name="PULSE_ENABLED" value="false"/>
         <env name="QUEUE_CONNECTION" value="database"/>
         <env name="SESSION_DRIVER" value="array"/>
         <env name="TELESCOPE_ENABLED" value="false"/>
         <env name="FIREBASE_CREDENTIALS" value=""/>
+
     </php>
 </phpunit>

tests/Feature/NegativeBalanceTest.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace Tests\Feature;
+
+use App\Models\User;
+use App\Models\Wallet;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+use Whilesmart\ModelConfiguration\Enums\ConfigValueType;
+
+class NegativeBalanceTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Test that a transaction fails if balance is insufficient and config is OFF.
+     */
+    public function test_transaction_fails_when_insufficient_funds_and_config_disabled()
+    {
+        $user = User::factory()->create();
+        $wallet = Wallet::factory()->create(['user_id' => $user->id, 'balance' => 10.00]);
+
+        // Explicitly set allow-negative-balance to false
+        $user->setConfigValue('allow-negative-balance', false, ConfigValueType::Boolean);
+
+        $payload = [
+            'amount' => 50.00, // More than the 10.00 balance
+            'type' => 'expense',
+            'wallet_id' => $wallet->id,
+            'description' => 'Overdraft attempt',
+        ];
+
+        $response = $this->actingAs($user, 'sanctum')->postJson('/api/v1/transactions', $payload);
+
+        // It should fail because the TransferService (or Controller) throws an error
+        $response->assertStatus(422);
+        $this->assertEquals(10.00, $wallet->fresh()->balance);
+    }
+
+    /**
+     * Test that a transaction succeeds if balance is insufficient but config is ON.
+     */
+    public function test_transaction_succeeds_when_insufficient_funds_and_config_enabled()
+    {
+        $user = User::factory()->create();
+        $wallet = Wallet::factory()->create(['user_id' => $user->id, 'balance' => 10.00]);
+
+        // Enable negative balance for this user
+        $user->setConfigValue('allow-negative-balance', true, ConfigValueType::Boolean);
+
+        $payload = [
+            'amount' => 50.00,
+            'type' => 'expense',
+            'wallet_id' => $wallet->id,
+            'description' => 'Allowed overdraft',
+        ];
+
+        $response = $this->actingAs($user, 'sanctum')->postJson('/api/v1/transactions', $payload);
+
+        // Assert success
+        $response->assertStatus(201);
+
+        // Assert the warning exists in the response JSON
+        // $response->assertJsonPath('warning', __('Your account is now in a negative balance.'));
+
+        // Assert the database reflects a negative balance (-40)
+        $this->assertEquals(-40.00, (float)$wallet->fresh()->balance);
+    }
+}