Skip to content

Migrate all ActiveJobs to Sidekiq jobs #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Migrate all ActiveJobs to Sidekiq jobs #699

wants to merge 16 commits into from

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Dec 18, 2024

With this change, we are moving to a uniform way of creating jobs in Tramline.

Changes:

  • Change ApplicationJob to include Sidekiq::Job
  • Add low priority queue for jobs that don't affect release runtime
  • Add Sentry context of Job and Domain in a Sidekiq middleware
  • Remove using keyword args for jobs since Sidekiq expects simple arguments, move them to Hash with stringified keys
  • Add a warning for strict args check in local dev env, but disable it for production

Sentry context for better debugging:

Screenshot 2025-01-27 at 9 46 24 PM

@gitstart-tramline
Copy link

Hi @kitallis, PR is ready for review.

Copy link
Member

@kitallis kitallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we first get this updated with the latest main?
It'll be easier to review since there's a lot of code that has been deleted.

@gitstart-tramline
Copy link

Could we first get this updated with the latest main? It'll be easier to review since there's a lot of code that has been deleted.

Sure, we will resolve the conflicts and update the PR

@gitstart-tramline
Copy link

Hi @kitallis,
We have resolved the conflicts, please review.

@nid90 nid90 requested a review from kitallis January 27, 2025 16:15
@nid90 nid90 requested a review from kitallis January 27, 2025 20:25
@nid90 nid90 closed this Jan 31, 2025
@nid90
Copy link
Member

nid90 commented Jan 31, 2025

Merged via CLI.

@kitallis kitallis deleted the TRAB-690 branch February 11, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants