-
Notifications
You must be signed in to change notification settings - Fork 24
Migrate all ActiveJobs to Sidekiq jobs #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @kitallis, PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we first get this updated with the latest main
?
It'll be easier to review since there's a lot of code that has been deleted.
Sure, we will resolve the conflicts and update the PR |
Hi @kitallis, |
Merged via CLI. |
With this change, we are moving to a uniform way of creating jobs in Tramline.
Changes:
ApplicationJob
to includeSidekiq::Job
Job
andDomain
in a Sidekiq middlewareSentry context for better debugging: