Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Prefer SSL connection to source #181

Merged
merged 2 commits into from
May 9, 2024
Merged

Prefer SSL connection to source #181

merged 2 commits into from
May 9, 2024

Conversation

louis-pie
Copy link
Contributor

@louis-pie louis-pie commented May 9, 2024

Context

Currently, tap-mysql will only connect without SSL, unless certificates are specified. Going forward, source servers really need to be protected a little better if possible.

Proposed changes

Attempt SSL connection without certificate before falling back to regular connections

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@wise-github-bot-app
Copy link

🔴

Your CODEOWNERS file is broken, fix the following errors before merging the branch:

  • The CODEOWNERS file does not exist. Repository ownership will default to ENGINEERING until you add a CODEOWNERS file with a * rule that assigns it to a team

@wise-github-bot-app
Copy link

The approval(s) from amofakhar do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGPLA, maps to the PLATFORM business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@louis-pie louis-pie merged commit 75a56e1 into master May 9, 2024
11 of 12 checks passed
@louis-pie louis-pie deleted the AP-1693 branch May 9, 2024 12:43
@wise-github-bot-app
Copy link

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Synced Comment
analytics-platform 🟢 Team updated with role owner
@tw-census 🟢 User added with role admin

You have more info in the docs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants