Merge pull request #2 from transferwise/disable-signals

transferwise · May 7, 2024 · 8799193 · 8799193
2 parents fa2572a + 506f334
commit 8799193
Showing 1 changed file with 20 additions and 16 deletions.
diff --git a/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_Signal.c b/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_Signal.c
@@ -208,22 +208,26 @@ static void uninstallSignalHandler(void)
 
 static void setEnabled(bool isEnabled)
 {
-    if(isEnabled != g_isEnabled)
-    {
-        g_isEnabled = isEnabled;
-        if(isEnabled)
-        {
-            rcid_generate(g_eventID);
-            if(!installSignalHandler())
-            {
-                return;
-            }
-        }
-        else
-        {
-            uninstallSignalHandler();
-        }
-    }
+//    Wise: Wise has tooling already in place for crash reports, so we don't want to set a crash handler when
+//    setting up Rollbar. Currently there's no option to disable this from the public API of the Rollbar SDK.
+//    Rollbar have placed this into their feature backlog, which we should adopt once available.
+//
+//    if(isEnabled != g_isEnabled)
+//    {
+//        g_isEnabled = isEnabled;
+//        if(isEnabled)
+//        {
+//            rcid_generate(g_eventID);
+//            if(!installSignalHandler())
+//            {
+//                return;
+//            }
+//        }
+//        else
+//        {
+//            uninstallSignalHandler();
+//        }
+//    }
 }
 
 static bool isEnabled(void)