Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACCMOB] Diagnostic for exception handling #3

Merged
merged 4 commits into from
May 15, 2024

Conversation

AleManniTW
Copy link

@AleManniTW AleManniTW commented May 13, 2024

Description of the change

We keep tracking some crashes despite commenting out some code in sdk.
This should help to clarify if these logs are sent by RollbarCarshMonitor or not.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@AleManniTW AleManniTW added the change:standard Not an emergency or impactful change label May 13, 2024
@AleManniTW AleManniTW changed the title Disable Handle exception tout court [ACCMOB] Diagnostic for exception handling May 14, 2024
@AleManniTW AleManniTW marked this pull request as ready for review May 14, 2024 10:42
@AleManniTW AleManniTW force-pushed the Set-explciitly-Crash-enabled-BOOL branch from d00b129 to 5ab9b1f Compare May 15, 2024 10:19
@AleManniTW AleManniTW merged commit e6395a7 into master May 15, 2024
2 checks passed
@AleManniTW AleManniTW deleted the Set-explciitly-Crash-enabled-BOOL branch May 15, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:standard Not an emergency or impactful change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants