Fixes stopping of wrong scheduled tasks #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onukristo
force-pushed
the
schedule_tasks_fix
branch
from
b803fa5 to
73c9436
Compare
jordanhasgul
reviewed
Jan 3, 2024
| @@ -22,7 +22,7 @@ public void afterPropertiesSet() { | |||
| try { | |||
| if (!initialized) { | |||
| executorService = Executors.newCachedThreadPool(new CountingThreadFactory("tw-base")); | |||
| scheduledTaskExecutor = new SimpleScheduledTaskExecutor(null, executorService); | |||
| scheduledTaskExecutor = new SimpleScheduledTaskExecutor("gste", executorService); | |||
There was a problem hiding this comment.
What does "GSTE" mean here?
There was a problem hiding this comment.
Global scheduled task executor.
jordanhasgul
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently when a scheduled task was stopped by its handle, it caused the stoppage of all tasks which had the same delay left.
Fixes stopping of wrong scheduled tasks.
Checklist