Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity string is at MotionActivityEvent.type #1335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisdrackett
Copy link

No description provided.

Copy link

@oliverdolgener oliverdolgener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@Wunsz
Copy link

Wunsz commented Aug 16, 2022

Why not set the actual types instead of string?

 'still' | 'on_foot' | 'walking' | 'running' | 'in_vehicle' | 'on_bicycle'

I raised my own PR that changes both erros:
#1524

@tsachit
Copy link

tsachit commented Dec 30, 2022

any update here?

@david-gettins
Copy link

There hasn't been any movement on this since August last year so I took the liberty of creating a new PR that resolves the union type comment. Please see #1624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants