feat(train-popover): add last updated date and predicted departure #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend
|
Am I misunderstanding something, but why is last updated older than departure? Wouldn't departure be an update? Maybe it should be more clear what it means |
|
@devinmatte yeah, that is when the API last updated the position data about the vehicle. I agree it's not very clear... would something like "Poisition updated" be clearer? Also for the Departure, I think I should probably change that to |
devinmatte
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #184
Changes
Testing Instructions
Run locally and verify that the last updated date and predicted departure appear for trains on each line